Bug 12653 - update machine config files removing deprecated "SERIAL_CONSOLE"
Summary: update machine config files removing deprecated "SERIAL_CONSOLE"
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 2.4
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 4.99
Assignee: Maciej Pijanowski
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2018-04-04 18:41 UTC by Stephano Cetola
Modified: 2018-09-26 10:50 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Yes (doc changes required)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephano Cetola 2018-04-04 18:41:05 UTC
We deprecated SERIAL_CONSOLE in 2013, yet many of our machine files still use the variable:

x86-base.inc
mpc8315e-rdb.conf
edgerouter.conf
beaglebone-yocto.conf

This is confusing to users looking to us for an example.
Comment 1 Stephano Cetola 2018-04-04 18:59:46 UTC
Note that this will require that documentation be changed since we use the beaglebone as our example here:

https://www.yoctoproject.org/docs/2.5/bsp-guide/bsp-guide.html#creating-a-new-bsp-layer-using-the-bitbake-layers-script
Comment 2 Denys Dmytriyenko 2018-04-05 08:03:54 UTC
Stephano, can you please provide a link to deprecation notice from 2013 for the record? Thanks.
Comment 4 Maciej Pijanowski 2018-08-06 19:29:58 UTC
Currently, following machine configuration files seem to need the transition
from SERIAL_CONSOLE to SERIAL_CONSOLES:

./meta-yocto-bsp/conf/machine/mpc8315e-rdb.conf:SERIAL_CONSOLE = "115200 ttyS0"
./meta-yocto-bsp/conf/machine/edgerouter.conf:SERIAL_CONSOLE = "115200 ttyS0"
./meta-yocto-bsp/conf/machine/beaglebone-yocto.conf:SERIAL_CONSOLE = "115200 ttyO0"
./meta/conf/machine/include/x86-base.inc:SERIAL_CONSOLE ?= "115200 ttyS0"

There is also the serialgetty recipe which still uses SERIAL_CONSOLE:

./meta/recipes-core/systemd/systemd-serialgetty.bb:SERIAL_CONSOLE ?= "115200 ttyS0"

If we want to leave the default value, I think we should still transition it to
SERIAL_CONSOLES. The recipe is already using SERIAL_CONSOLES variable internally
in the do_install().
Comment 5 Maciej Pijanowski 2018-08-22 20:01:15 UTC
As suggested on the oe-core ML, patch was send to the poky ML: https://lists.yoctoproject.org/pipermail/poky/2018-August/011462.html
Would that be the correct place for it?
Comment 6 Ross Burton 2018-09-26 10:50:35 UTC
Merged in:

meta-yocto a0c5332aefe75cf314e78284f578b17c51b8ab27
OE-Core e5bde3d466869df9fce559e49842ac245153d045