Bug 12674 - devtool modify does not preserve patch header after scissors line
Summary: devtool modify does not preserve patch header after scissors line
Status: NEW
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: Scripts and Tools (show other bugs)
Version: 2.4
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 5.99
Assignee: Paul Eggleton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2018-04-11 15:09 UTC by Paul Eggleton
Modified: 2025-02-14 16:48 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Eggleton 2018-04-11 15:09:52 UTC 
If a patch includes text after the scissors line (such as Upstream-status: or really any other explanatory text) then when devtool generates a git tree from the patches, that text is lost. The culprit is actually git, which ignores that text and thus it never makes it into the commit message, so when patches are re-generated from the git tree, the text isn't there anymore.
Comment 1 Denys Dmytriyenko 2018-04-12 18:37:13 UTC 
Another case where Upstream-status got lost:
http://lists.openembedded.org/pipermail/openembedded-devel/2018-April/117833.html

This time around it was too early in the patch headers, not the patch body where description goes...
Comment 2 Randy MacLeod 2023-10-24 14:24:42 UTC 
Bulk move from 4.99 or 0.00 to 5.99
Comment 3 Randy MacLeod 2025-02-14 16:46:26 UTC 
bulk change to add Saul's non-WR address.
Comment 4 Randy MacLeod 2025-02-14 16:48:21 UTC 
Bulk change: Remove Saul's old WR address.