Bug 12739 - Fetcher for Git submodules ('gitsm') bypasses BB_NO_NETWORK checks
Summary: Fetcher for Git submodules ('gitsm') bypasses BB_NO_NETWORK checks
Status: RESOLVED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.6 M1
Assignee: Richard Purdie
QA Contact:
URL:
Whiteboard: Backport to YP 2.4 and 2.5
Depends on:
Blocks:
 
Reported: 2018-05-09 12:06 UTC by Matt Hoosier
Modified: 2018-06-28 22:37 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Remember to copy fetched .git/modules into working copy clone (1.77 KB, application/octet-stream)
2018-05-09 12:06 UTC, Matt Hoosier 		no flags Details
Remember to copy fetched .git/modules into working copy clone (1.78 KB, patch)
2018-05-09 14:34 UTC, Matt Hoosier 		no flags Details | Diff
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Hoosier 2018-05-09 12:06:24 UTC 
Created attachment 4298 [details]
Remember to copy fetched .git/modules into working copy clone

As a consequence of accidentally not propagating the .git/modules directory (the histories of the submodules) as downloaded during the do_fetch() task into the repo cloned into ${WORKDIR}, the do_unpack() task inadvertently performs a live fetch of each submodule listed in .gitmodules in order to satisfy the 'git submodule update --init --recursive' command executed during the unpack task.

The attached patch contains a proposes to fix the issue by propagating the .git/modules to the working copy clone.
Comment 1 Matt Hoosier 2018-05-09 14:34:26 UTC 
Created attachment 4299 [details]
Remember to copy fetched .git/modules into working copy clone
Comment 2 Matt Hoosier 2018-05-10 03:53:00 UTC 
Comment on attachment 4299 [details]
Remember to copy fetched .git/modules into working copy clone

Removed the patch attachment; it's submitted on bitbake-devel.