Bug 12742 - buildhistory doesn't like files with whitespace
Summary: buildhistory doesn't like files with whitespace
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: devtools / tool chain (show other bugs)
Version: 2.5
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 2.6 M2
Assignee: Paul Eggleton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2018-05-10 07:00 UTC by Ross Burton
Modified: 2018-07-19 14:55 UTC (History)
2 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Burton 2018-05-10 07:00:35 UTC 
A recent version of gtk-doc added a file with a name something like this:

/usr/share/gtk-doc/html/templatate (devel).xml

However buildhistory writes the FILELIST by writing a whitespace separated list of filenames, without considering whitespace in filenames.

My ugly hack fix here to stop buildhistory-diff breaking (and thus my automated builds) is:

--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
-        filelist = list(dictval.keys())
+        filelist = [urllib.parse.quote(k) for k in dictval.keys()]

That doesn't handle making it transparent for loading though.
Comment 1 Paul Eggleton 2018-07-11 15:04:16 UTC 
I just sent a patch for this, however for anyone else testing, FYI a reasonable test file would in fact be usr/lib/python2.7/site-packages/setuptools/script (dev).tmpl in python-setuptools rather than what was suggested above.
Comment 2 Ross Burton 2018-07-19 14:55:02 UTC 
Fixed in oe-core c258379181a438cb01728d223b3d05e0ab205941.