Bug 12752 - Check that patches don't have a github /archive/ URL
Summary: Check that patches don't have a github /archive/ URL
Status: RESOLVED FIXED
Alias: None
Product: Patchwork/Patchtest
Classification: Yocto Project Subprojects
Component: Patchtest Testsuite (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 4.99
Assignee: Tim Orling
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2018-05-16 03:55 UTC by Ross Burton
Modified: 2022-08-04 14:58 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Burton 2018-05-16 03:55:40 UTC
We shouldn't be using github /archive/ URLs in recipes because the resulting tarball isn't reliable.

For example https://github.com/madler/pigz/archive/v1.2.tar.gz

Vague pseudo-expression to match is https?://github.com/*/*/archive/*

Patchtest should check for this and emit an error.
Comment 1 Trevor Woerner 2018-05-16 14:18:05 UTC
or:
    grep -r -l -E github\\.com/.*/archive/ *
Comment 2 Randy MacLeod 2020-03-26 17:26:14 UTC
Paul, would you like to add this check?