Bug 13319 - Add SPDX license headers to all source files for matchbox/sato
Summary: Add SPDX license headers to all source files for matchbox/sato
Status: RESOLVED FIXED
Alias: None
Product: Sato
Classification: Yocto Project Subprojects
Component: Matchbox (show other bugs)
Version: svn
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 3.2 M3
Assignee: Matthew Zeng
QA Contact:
URL:
Whiteboard: NEWCOMER
Depends on:
Blocks:
 
Reported: 2019-05-02 13:02 UTC by Richard Purdie
Modified: 2020-08-17 08:41 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Purdie 2019-05-02 13:02:55 UTC
We should model best practices and clean up the matchbox/sato codebase to have SPDX license headers in all the source files.
Comment 1 Randy MacLeod 2019-05-02 14:49:54 UTC
https://spdx.org/licenses/
Also see the bitbake repository.
Comment 2 David Reyna 2019-06-19 10:44:35 UTC
To be clear, the scope is just this directory?

  meta/recipes-sato/matchbox-sato

Or is is all "matchbox" content within the "recipe-sato" directory?

  [recipes-sato]$ ls -d *matchbox*
  matchbox-config-gtk  matchbox-desktop  matchbox-keyboard  
  matchbox-panel-2     matchbox-sato     matchbox-terminal  
  matchbox-theme-sato
  [recipes-sato]$ 

- David
Comment 3 Ross Burton 2019-06-20 15:17:05 UTC
Matchbox is the window manager, Sato is the desktop using Matchbox, matchbox-sato itself is just some glue.  The scope is all of the matchbox-* recipes.
Comment 4 Matthew Zeng 2020-03-20 16:36:16 UTC
Is this adding license headers to all matchbox-* source files in http://git.yoctoproject.org/ or adding them to recipe files in meta/recipes-sato/matchbox-* ?
Comment 5 Ross Burton 2020-03-20 16:47:04 UTC
The former: adding to the source, not the recipes.
Comment 6 Matthew Zeng 2020-03-20 18:35:59 UTC
From the repositories, it's unclear which SPDX License does matchbox apply. Is it same as Yocto itself, which is MIT?
Comment 7 Randy MacLeod 2020-03-20 18:55:46 UTC
Some are pretty clear since they have a COPYING file in the top dir, eg:
http://git.yoctoproject.org/cgit/cgit.cgi/matchbox-desktop-2/tree/COPYING

Start with the clear ones and then make a list of the ones that are less clear and ask here again. Thanks.
Comment 8 Matthew Zeng 2020-03-26 19:39:57 UTC
I've submitted two patches to add SPDX license identifiers for now, please let me know if the format is correct.

- matchbox-config-gtk: https://lists.yoctoproject.org/g/yocto/topic/72494583
- matchbox-desktop-2: https://lists.yoctoproject.org/g/yocto/topic/72495096

Once confirmed and merged, I'll send patches for the rest of matchbox-* packages.
Comment 9 Matthew Zeng 2020-04-15 08:16:53 UTC
Can I get an update on the patches I sent? It isn't merged so I have to move this bug to 3.2.
Comment 10 Matthew Zeng 2020-08-06 08:43:01 UTC
I never received an update. But today I checked that those two patches are indeed merged in May, I'll submit rest of the patches to fix this issue.

The first one is matchbox-desktop: https://lists.yoctoproject.org/g/yocto/topic/matchbox_desktop_patch_add/76030636
Comment 11 Matthew Zeng 2020-08-06 09:38:59 UTC
v2 of matchbox-desktop: https://lists.yoctoproject.org/g/yocto/topic/matchbox_desktop_patchv2/76032128
Comment 13 Randy MacLeod 2020-08-15 13:02:05 UTC
Matthew, I think you fixed all the MB repos. Please close the ER and if we find something that was missed, we'll deal with it. Thanks!