Bug 13628 - Sort files in do_image_cpio for reproducibility
Summary: Sort files in do_image_cpio for reproducibility
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 3.0
Hardware: x86 Multiple
: Medium normal
Target Milestone: 3.1
Assignee: Ross Burton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2019-11-15 11:56 UTC by Ernst Persson
Modified: 2019-12-11 10:10 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Patch (1.38 KB, patch)
2019-11-15 11:56 UTC, Ernst Persson 		no flags Details | Diff
Patch v2 (1.44 KB, patch)
2019-12-03 08:27 UTC, Ernst Persson 		no flags Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ernst Persson 2019-11-15 11:56:02 UTC 
Created attachment 4586 [details]
Patch

Find list files in the order that the filesystem has registered them
which can vary. Adding a sort should have minimal performance impact.
This should be done in
meta/classes/image_types.bbclass
Comment 1 Ernst Persson 2019-11-15 15:07:17 UTC 
There's a --reproducible option to cpio also. Perhaps make it optional under BUILD_REPRODUCIBLE_BINARIES ?
Comment 2 Ross Burton 2019-11-15 19:30:17 UTC 
--reproducible doesn't sort so you'll need to do both.

I prefer harmless changes to be done always instead of only in reproducible builds, less combinations for testing.

Patches go to the mailing list not bugzilla, so can you please post using git-send-email to openembedded-core@lists.openembedded.org?
Comment 3 Ernst Persson 2019-11-15 23:54:54 UTC 
> --reproducible doesn't sort so you'll need to do both.

Yes I meant in addition to.

> I prefer harmless changes to be done always instead of only in reproducible builds, less combinations for testing.

Sounds good.

> Patches go to the mailing list not bugzilla, so can you please post using git-send-email to openembedded-core@lists.openembedded.org?

right, of course.
Comment 4 Ernst Persson 2019-12-03 08:27:49 UTC 
Created attachment 4593 [details]
Patch v2