Bug 13642 - Split single "run-config" step into multiple steps
Summary: Split single "run-config" step into multiple steps
Status: RESOLVED FIXED
Alias: None
Product: AutoBuilder
Classification: Infrastructure
Component: autobuilder (show other bugs)
Version: 3.1
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 3.3 M1
Assignee: Richard Purdie
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2019-11-21 19:52 UTC by Richard Purdie
Modified: 2020-11-12 15:16 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Yes (doc changes required)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Purdie 2019-11-21 19:52:44 UTC
Currently the autobuilder has one step "run-config" which runs multiple different steps internally. These go to different log files with confusing names like "step2d". The reason is we can't know in advance how many steps a given target on the autobuilder will have in a given release.

From buildbot irc:
(15:40:01) aakashja_: RP: they definitely can be added dynamically at execution time based on the data from worker. We do that in WebKit.
(15:40:48) aakashja_: RP: for example in https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/steps.py#L113 if the CheckOutSource fails, we invoke CleanUpGitIndexLock build-step.
Aaeriele aakashja_ 
(16:22:44) RP: aakashja_: addStepsAfterCurrentStep sounds promising, an example really helps, thanks!
(16:46:22) aakashja_: RP: this is how that dynamic step look like in buildbot build: https://ews-build.webkit.org/#/builders/4/builds/2570

so we should be able to have a step query how many steps a given build run has, then dynamically create them with addStepsAfterCurrentStep(). Bonus marks for creating human readable names for the steps (we could add this to config.json if there were a good way to display it which there now is).

The benefit of doing this would be more understandable logs for users which would show individual execution times and warnings/errors.