Bug 13881 - Bitdoc broken in latest and prior releases, remove or fix?
Summary: Bitdoc broken in latest and prior releases, remove or fix?
Status: RESOLVED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: unspecified
Hardware: All Multiple
: Medium+ enhancement
Target Milestone: 3.2 M1
Assignee: Richard Purdie
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2020-04-22 03:33 UTC by frazer.clews
Modified: 2020-05-02 03:02 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know


Attachments
WIP patch to get bitdoc working (5.61 KB, patch)
2020-04-22 03:34 UTC, frazer.clews
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description frazer.clews 2020-04-22 03:33:39 UTC
I noticed there's a binary for bitdoc, it's been broken for a long time but can't see if it's not meant to be used or not. I have made a WIP patch to fix it, but should it be removed maybe if it's not intended, if so I will make a patch to remove it to make the codebase better. I will leave the WIP patches in the attachments, thanks
Comment 1 frazer.clews 2020-04-22 03:34:14 UTC
Created attachment 4670 [details]
WIP patch to get bitdoc working
Comment 3 frazer.clews 2020-04-23 08:59:27 UTC
Yeah, that's specifically what I am talking about
Comment 4 Richard Purdie 2020-04-29 08:40:47 UTC
Thanks, I've done a review of what this script was doing and I'm going to propose a patch to delete it. I did use your code to see what it actually did though, thanks!
Comment 5 frazer.clews 2020-04-29 08:48:16 UTC
I agree that it may need removing, although I will say I am not 100% confident the `replace` function works as intended. Since I can't seem to replicate the original behaviour when this did work, just mentioning since you used my patch to test it
Comment 6 Richard Purdie 2020-04-30 12:34:03 UTC
Thanks, I think even accounting for some issues like the replace function, this script has been superseded by the data in the manuals. I wanted to double check there wasn't anything in here we were missing but I don't think there is.
Comment 7 Richard Purdie 2020-05-02 03:02:03 UTC
Its gone:
http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=7a5cc8659e4ba8f36bcb5322e246005d812efb59
thanks for pointing it out.