Bug 14107 - The libopkg source should consistently use stdbool for its boolean value implementation, for currency and consistency.
Summary: The libopkg source should consistently use stdbool for its boolean value impl...
Status: ACCEPTED
Alias: None
Product: opkg
Classification: Yocto Project Subprojects
Component: opkg (show other bugs)
Version: 0.4.4
Hardware: All Multiple
: Undecided enhancement
Target Milestone: next-patch
Assignee: Alex Stewart
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2020-10-23 11:10 UTC by Alex Stewart
Modified: 2021-07-08 14:58 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Stewart 2020-10-23 11:10:38 UTC
1. Feature Description:
In this recent patchset[1], @Alex Stewart used stdbool.h and the bool type it provided to implement a new attribute for libopkg commands. This is a contemporary and reasonable approach, but it differs from other boolean implementations in the codebase - where the other implementations use C int primitives to encode boolean. The patchset has been accepted upstream on the understanding that we will standardize the boolean implementation at a later date.

There's no time like the present. Update all the boolean implementations in the libopkg codebase to use stdbool - except where obviously inappropriate.

[1] https://groups.google.com/forum/#!topic/opkg-devel/UucYATiuHKU

2. Feature Present Code Status(including location and version):
N/A

3. Code License (e.g. GPLv2):
N/A

4. Business Impaction:
None

5. Other Justification:
Maintainability of the libopkg codebase benefits from currency and consistency.