Tree/Branch: master Commit: 6c2b7beac3cd23ed44bd3e195c6360a0932876bf With latest master, when we click some package, like avahi, some packages will have duplicated "brought in by" packages. For example, e2fsprogs-badblocks is brought in by e2fsprogs and there are a lot of e2fsprogs in "brought in by" column.
I believe this is describing the intended behaviour caused by two recent changes. Firstly, we switched to storing all packages provided by a recipe, rather than just the recipe itself, in the data model and operating at a package level of granularity. Further, and per bug 1365, we switched to listing all of the reverse dependencies of a package in the 'Brought in by' column, rather than just the first package which brought the package in. I believe this issue is appropriate to change to RESOLVED->NOTABUG, do you agree? We do have bug 1423 querying the legitimacy of the entries in the 'Brought in by' column
(In reply to comment #1) > I believe this is describing the intended behaviour caused by two recent > changes. > Firstly, we switched to storing all packages provided by a recipe, rather than > just the recipe itself, in the data model and operating at a package level of > granularity. > Further, and per bug 1365, we switched to listing all of the reverse > dependencies of a package in the 'Brought in by' column, rather than just the > first package which brought the package in. > I believe this issue is appropriate to change to RESOLVED->NOTABUG, do you > agree? > We do have bug 1423 querying the legitimacy of the entries in the 'Brought in > by' column Hi Josh, The issue I meet is that if I select/deselect avahi for N times, N duplicated package name will be shown up in "Brought in By". You could have a try with avahi and check "Brought in By" column for package e2fsprogs-badblocks. I find you have a patch to fix duplicated item to binb column as below. Will the patch fix the issue? Signed-off-by: Joshua Lock <josh@linux.intel.com> --- lib/bb/ui/crumbs/tasklistmodel.py | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/bb/ui/crumbs/tasklistmodel.py b/lib/bb/ui/crumbs/tasklistmodel.py index 5ff1f5a..cf9fc59 100644 --- a/lib/bb/ui/crumbs/tasklistmodel.py +++ b/lib/bb/ui/crumbs/tasklistmodel.py @@ -441,8 +441,9 @@ class TaskListModel(gtk.ListStore): self[item_path][self.COL_INC] = True bin = self[item_path][self.COL_BINB].split(', ') - bin.append(binb) - self[item_path][self.COL_BINB] = ', '.join(bin).lstrip(', ') + if not binb in bin: + bin.append(binb) + self[item_path][self.COL_BINB] = ', '.join(bin).lstrip(', ') # We want to do some magic with things which are brought in by the # base image so tag them as so -- 1.7.6
Ah, thanks for clarifying! The patch you mention helps but there's a second loop in the same method that potentially modifies COL_BINB. I have a patch queued for submission to ensure duplicates aren't added there too.
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e2a3f283304e46b05e4900607d0568aec9b41f22
Verified in master:4d8ab87d25ea6e59dc88375813ef88ee0ac813d0.
Verified.