Bug 14529 - devtool/recipetool does not use SPDX-License-Identifier headers to determine license(s)
Summary: devtool/recipetool does not use SPDX-License-Identifier headers to determine ...
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: devtools / tool chain (show other bugs)
Version: 3.4
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 4.0 M3
Assignee: Saul Wold
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2021-08-26 14:57 UTC by Tim Orling
Modified: 2025-02-14 16:48 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Orling 2021-08-26 14:57:31 UTC
When creating a new recipe with:
$ devtool add python3-pyinstaller-hooks-contrib https://files.pythonhosted.org/packages/a6/81/0a27c73014cbc9cc5623fd32f570d3daff7ad88999ecb4317cc6c6fd9db7/pyinstaller-hooks-contrib-2021.3.tar.gz

the resulting recipe has:
# The following license files were not able to be identified and are
# represented as "Unknown" below, you will need to check them yourself:
#   LICENSE
#   LICENSE.APL.txt
#   LICENSE.GPL.txt
LICENSE = "Unknown"
LIC_FILES_CHKSUM = "file://LICENSE;md5=822bee463f4e00ac4478593130e95ccb \
                    file://LICENSE.APL.txt;md5=9f445e374fa8f653a9654c10468ffc36 \
                    file://LICENSE.GPL.txt;md5=757586685e1b7938627f468f1b05b2dc"

When clearly it could have determined the Apache-2.0 and GPL-2.0-or-later, as those are called out in two of the license files:

LICENSE.APL.txt excerpt:
# ------------------------------------------------------------------
# Copyright (c) 2021 PyInstaller Development Team.
#
# This file is distributed under the terms of the Apache License 2.0
#
# The full license is available in LICENSE.APL.txt, distributed with
# this software.
#
# SPDX-License-Identifier: Apache-2.0
# ------------------------------------------------------------------
(followed by the Apache 2.0 text)

LICENSE.GPL.txt excerpt:
# ------------------------------------------------------------------
# Copyright (c) 2021 PyInstaller Development Team.
#
# This file is distributed under the terms of the GNU General Public
# License (version 2.0 or later).
#
# The full license is available in LICENSE.GPL.txt, distributed with
# this software.
#
# SPDX-License-Identifier: GPL-2.0-or-later
# ------------------------------------------------------------------
(followed by the GPL-2.0-or-later text)

The expected behavior would have been to set:
LICENSE = "Apache-2.0 & GPL-2.0-or-later & UNKNOWN"

(since the third file does not have license text in it but rather describes the other two files.
Comment 2 Randy MacLeod 2025-02-14 16:46:20 UTC
bulk change to add Saul's non-WR address.
Comment 3 Randy MacLeod 2025-02-14 16:48:10 UTC
Bulk change: Remove Saul's old WR address.