Bug 14876 - rust: Improve reproducibility patch
Summary: rust: Improve reproducibility patch
Status: RESOLVED OBSOLETE
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: devtools / tool chain (show other bugs)
Version: 0.0.0
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 5.2 M1
Assignee: Unassigned
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2022-08-09 13:16 UTC by Richard Purdie
Modified: 2025-01-17 03:48 UTC (History)
7 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Purdie 2022-08-09 13:16:24 UTC
I added a patch to work around rust reproducibility issues. We need to investigate these and find a better solution perhaps working with upstream.

https://git.yoctoproject.org/poky/commit/?id=411304c3e99f6d3320cb307a61b5d03eda9f7b4d
Comment 1 Randy MacLeod 2023-08-04 21:16:17 UTC
Yash, this is mainly for master/4.3-M3.
Comment 2 Randy MacLeod 2025-01-14 20:22:50 UTC
This patch was dropped with a link to an upstream commit in:
https://git.openembedded.org/openembedded-core/commit/?id=611ec9ffbac974f472a828277ba7f3e344e99ca3

Deepesh, 

Can you review and confirm in a comment that the commit linked to, really does touch the same code or in some other way eliminate the need for this patch.
I sent some time on that but didn't get to a complete understanding.

The patch was originally added to oe-core in:

commit 411304c3e99f6d3320cb307a61b5d03eda9f7b4d
Author: Richard Purdie <richard.purdie@linuxfoundation.org>
Date:   Wed Aug 3 10:10:00 2022

    rust: Work around reproducibility issues
    
    Add a patch which removes the sections of code which encode buildpaths. Whilst
    not ideal, the patches at least show where the problematic data is coming from
    and should allow more focused work to resovle it by someone who has a better
    understanding of rust and what this code is doing. It does look unlikely we
    actually need this code in our usecases anyway.
    
    (From OE-Core rev: c08c522fc29445aef0c64f0dd8df8a3531c04afa)


Ideally, there would be a more verbose oe-core commit log so that someone who isn't involved in the day to day Rust work can easily see what the overlap is
and understand in a reasonable time that the original problem is properly addressed upstream. Since we don't have any run-time tests failing and the build is reproducible, I don't doubt that we can drop the patch but I'm commenting so that in the future, I will be able to get that reassurance from the commit log.

Thanks. ../Randy
Comment 3 Randy MacLeod 2025-01-16 16:14:30 UTC
Patch dropped and tests work.