Bug 14939 - git core.fsyncObjectFiles is deprecated since git v2.36.0
Summary: git core.fsyncObjectFiles is deprecated since git v2.36.0
Status: RESOLVED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: 4.3
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 4.2 M2
Assignee: Ross Burton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2022-10-17 13:36 UTC by Martin Jansa
Modified: 2022-11-03 12:34 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Jansa 2022-10-17 13:36:50 UTC 
It was replaced with more granular approach in:
https://github.com/git/git/compare/a68dfadae5e95c7f255cf38c9efdcbc2e36d1931...b9f5d0358d2e882d47f496c1a5589f6cebc25578

and deprecated in:
https://github.com/git/git/commit/844a8ad4f868dcac8851012fe6dafd49b301b2ae#diff-74eb92dd55d0dc52d3107aedbba99f2d7d68ba12b8ecdf9132c7ba3385b3e405R1691

This results in a lot of warnings in do_fetch/do_unpack logs (e.g. shown in http://errors.yoctoproject.org/Errors/Details/672888/)

It's set in default FETCHCMD_git:

lib/bb/fetch2/git.py:        ud.basecmd = d.getVar("FETCHCMD_git") or "git -c core.fsyncobjectfiles=0 -c gc.autoDetach=false -c core.pager=cat"

People with newer git can set FETCHCMD_git locally, but we should plan some migration so that it works well OOTB.
Comment 1 Martin Jansa 2022-10-17 13:41:30 UTC 
$ grep -c "warning: core.fsyncObjectFiles is deprecated; use core.fsync instead" vulkan-samples/git-r0/temp/log.do_fetch
5
$ echo -e `grep FetchError vulkan-samples/git-r0/temp/log.do_unpack` | grep -c "warning: core.fsyncObjectFiles is deprecated; use core.fsync instead"
14
Comment 2 Richard Purdie 2022-10-28 17:01:12 UTC 
As far as I can tell, fsyncobjectfiles=0 is the default so we should just be able to drop this?
Comment 3 Ross Burton 2022-10-28 17:03:19 UTC 
Yes, looks like it.
Comment 4 Ross Burton 2022-10-28 17:15:48 UTC 
Patch on the list.