Bug 14998 - Poky missing update to SANITY_LOCALCONF_SAMPLE
Summary: Poky missing update to SANITY_LOCALCONF_SAMPLE
Status: RESOLVED FIXED
Alias: None
Product: Build Testing
Classification: QA/Testing
Component: sanity (show other bugs)
Version: 4.2
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 4.2 M3
Assignee: Michael Opdenacker
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2023-01-03 10:37 UTC by Michael Opdenacker
Modified: 2023-02-17 10:48 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Opdenacker 2023-01-03 10:37:15 UTC
In the current master version of Poky, we have:
meta/classes-global/sanity.bbclass:SANITY_LOCALCONF_SAMPLE ?= "${COREBASE}/meta*/conf/local.conf.sample"

While local.conf.sample is located in meta-poky/conf/templates/default/local.conf.sample

That's an issue in sanity.bbclass when it suggests to compare local.conf with local.conf.sample.

We have the correct value in OE-core though:
meta/classes-global/sanity.bbclass:SANITY_LOCALCONF_SAMPLE ?= "${COREBASE}/meta*/conf/templates/default/local.conf.sample"

I wonder why this wasn't updated in Poky.
Opening this bug to keep track of this issue.
Don't hesitate to reassign to a more appropriate component if necessary.
Comment 1 Richard Purdie 2023-02-07 10:34:25 UTC
Hi Michael, sorry it has taken me a while to look at this.

Note the wildcard in ${COREBASE}/meta*/conf/local.conf.sample

i.e. it can match meta-poky.

In the poky repository only

./meta-poky/conf/templates

exists and in the openembedded-core repository only:

./meta/conf/templates

exists so we should be ok with the message?
Comment 2 Michael Opdenacker 2023-02-09 18:13:07 UTC
I still believe the meta*/conf/local.conf.sample wildcard is wrong, because it doesn't match this path:
${COREBASE}/meta-poky/conf/templates/default/local.conf.sample

Try by yourself on Poky:
poky$ ls -la meta*/conf/local.conf.sample
ls: cannot access 'meta*/conf/local.conf.sample': No such file or directory

Shouldn't it be ${COREBASE}/meta*/conf/templates/default/local.conf.sample instead, as it is in OE-core?

Thank you for your support
Cheers
Michael.
Comment 3 Michael Opdenacker 2023-02-16 15:51:22 UTC
Re-assigning the bug to RP as the need-info question is for him.
Comment 4 Michael Opdenacker 2023-02-16 16:38:42 UTC
Richard, to fix this issue, I think that's enough to pull this commit from OE-core: https://git.openembedded.org/openembedded-core/commit/?id=214c3dc91ceb1557b62ad3a359c72cfc9b2bf4f0

I wonder why it didn't get pulled by the way.
Thanks
Comment 5 Richard Purdie 2023-02-16 17:12:38 UTC
(In reply to comment #4)
> Richard, to fix this issue, I think that's enough to pull this commit from
> OE-core:
> https://git.openembedded.org/openembedded-core/commit/
> ?id=214c3dc91ceb1557b62ad3a359c72cfc9b2bf4f0
> 
> I wonder why it didn't get pulled by the way.
> Thanks

I think I resolved this. The challenge is some of those files don't exist in poky.
Comment 6 Michael Opdenacker 2023-02-17 10:48:08 UTC
Works for me, thanks!
Closing the bug.