Bug 15097 - Feature request: add support for acls and xattrs
Summary: Feature request: add support for acls and xattrs
Status: RESOLVED FIXED
Alias: None
Product: opkg
Classification: Yocto Project Subprojects
Component: opkg (show other bugs)
Version: 0.5
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: next-minor
Assignee: Alex Stewart
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2023-04-06 11:18 UTC by Piotr Łobacz
Modified: 2024-02-08 22:10 UTC (History)
0 users

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Yes (doc changes required)


Attachments
opkg-build support ACLS and extended attributes (2.24 KB, patch)
2023-04-06 19:02 UTC, Piotr Łobacz
no flags Details | Diff
opkg_archive.c support ACLs, extended flags and attributes (1.57 KB, patch)
2023-04-06 19:03 UTC, Piotr Łobacz
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Łobacz 2023-04-06 11:18:28 UTC
Alex as we have already spoken and I have verified that everything is working properly can we add this feature?
Comment 1 Alex Stewart 2023-04-06 15:57:23 UTC
We can add this as a feature-request; but it sounds like you already have something working. If you can clean that up and submit it, I would be happy to merge it and close this item.
Comment 2 Piotr Łobacz 2023-04-06 19:02:47 UTC
Created attachment 4945 [details]
opkg-build support ACLS and extended attributes
Comment 3 Piotr Łobacz 2023-04-06 19:03:31 UTC
Created attachment 4946 [details]
opkg_archive.c support ACLs, extended flags and attributes
Comment 4 Piotr Łobacz 2023-04-06 19:05:57 UTC
These are my current patches I would rather like to have them done a little bit differently, meaning to add this support when acl and xattrs are being enabled in configure and also if libarchive is with this support already.

The problem is that I've never had experience with autoconf... I've more with CMake.
Comment 5 Piotr Łobacz 2023-07-10 08:28:06 UTC
Hi Alex, I have created finally the patches with additional autotools changes. Question is were would you like me to put these patches both for opkg and opkg-utils?
Comment 6 Piotr Łobacz 2023-07-10 09:04:43 UTC
(In reply to Piotr Łobacz from comment #5)
> Hi Alex, I have created finally the patches with additional autotools
> changes. Question is were would you like me to put these patches both for
> opkg and opkg-utils?

Ok I have managed to send the patches:
https://groups.google.com/g/opkg-devel/c/aEGL7XRXfaA - opkg
https://groups.google.com/g/opkg-devel/c/dYNHrLjDwg8 - opkg-utils
Comment 7 Alex Stewart 2023-07-10 21:27:08 UTC
Thanks, Piotr! I'm just getting back into the office from holidays in the US and catching up on threads. I'll review your patches tomorrow.
Comment 8 Piotr Łobacz 2023-07-20 20:50:02 UTC
Hi Alex, I have forgotten to mention here, that there is another patch for opkg due to the usage of posix format:

https://groups.google.com/g/opkg-devel/c/16kgZfJ26mQ
Comment 9 Alex Stewart 2023-07-21 14:31:50 UTC
That locale patch looks good to me. Thanks!

Strangely, I don't see that patch anywhere in my email :(. It's probably an issue on my end. I'll give it until the end of the day to propagate through; but if it doesn't, I might ask you to send it to me directly on Monday.
Comment 10 Piotr Łobacz 2023-07-21 15:46:33 UTC
(In reply to Alex Stewart from comment #9)
> That locale patch looks good to me. Thanks!
> 
> Strangely, I don't see that patch anywhere in my email :(. It's probably an
> issue on my end. I'll give it until the end of the day to propagate through;
> but if it doesn't, I might ask you to send it to me directly on Monday.

Sure thing. I can wait. Generally we still need to wait for Alexandre to test the whole patchset, which I have created for him today for the new master-next. 

Strangly this kind of errors:

opkg-build -Z xz -a "--memlimit=5% --threads=8" "" "" nativesdk-xcb-proto-dbg /home/pokybuild/yocto-worker/genericx86-64/build/build/tmp/work/i686-nativesdk-pokysdk-linux/nativesdk-xcb-proto/1.15.2-r0/deploy-ipks/i686-nativesdk' returned non-zero exit status 1

are not happening for me and I'm not even able to reproduce...
Comment 11 Piotr Łobacz 2023-07-24 16:30:29 UTC
OK this has been fixed but I have a new story for you which is on opkg-devel. Shortly, the --format=posix is causing the issue with packages reproducible builds which does not happen with --format=gnu.

This has to be investigate with tar devel team.
Comment 12 Piotr Łobacz 2023-08-04 09:00:23 UTC
Hi Alex, I do not know if my emails have reached you but I have succeeded with all reproducibility tests and thus I have re-send fixed patchset.

The only question is whether the patch for locales and opkg-build v6 have reached you?
Comment 13 Piotr Łobacz 2024-02-08 22:10:08 UTC
Patches applied, new versions released.