Bug 15145 - module conf files missing when KERNEL_SPLIT_MODULES=0
Summary: module conf files missing when KERNEL_SPLIT_MODULES=0
Status: RESOLVED FIXED
Alias: None
Product: Meta-yocto
Classification: Build System, Metadata & Runtime
Component: meta-yocto (show other bugs)
Version: unspecified
Hardware: All Multiple
: Medium normal
Target Milestone: 5.3
Assignee: Dixit Parmar
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2023-06-14 12:02 UTC by george.thopas
Modified: 2025-06-23 09:15 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
sample fix (kirkstone) (6.29 KB, patch)
2023-06-14 12:02 UTC, george.thopas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description george.thopas 2023-06-14 12:02:49 UTC
Created attachment 4955 [details]
sample fix (kirkstone)

/etc/modprobe.d/*.conf and /etc/modules-load.d/*.conf
files normally generated by 
KERNEL_MODULE_AUTOLOAD and KERNEL_MODULE_PROBECONF settings are not generated and included in the modules package when KERNEL_SPLIT_MODULES = 0
(they are if split is active)

I attached a quick kirkstone patch which fixes it for me.
Welcoming any better or alternative solutions. 

Thanks
Comment 1 Randy MacLeod 2023-06-15 14:46:23 UTC
Thanks for reporting the bug.

Does this happen with master?
Where did you get this code from? It looks it was copied from somewhere else, perhaps from oe-core/master and if so, we need to share a common function or something.
Comment 2 george.thopas 2023-06-20 06:20:38 UTC
(In reply to Randy MacLeod from comment #1)
> Thanks for reporting the bug.
> 
> Does this happen with master?

happens with any version as far as I can see

> Where did you get this code from? It looks it was copied from somewhere
> else, perhaps from oe-core/master and if so, we need to share a common
> function or something.

it uses snippets of  frob_metadata right above it. When split is active frob_metadata gets called as a hook to put the conf in each package. When split is disabled split_kernel_module_packages bails out at the point I inserted the extra call.
Comment 3 Randy MacLeod 2023-06-22 14:57:25 UTC
We're a little concerned about minimizing copy and paste but this was discussed on the Yocto bug review. Could you send a patch to the email list after reviewing your approach and some existing patches that were on the mailing list in the same code but doing something else?
-- YP bug review.
Comment 4 Randy MacLeod 2023-08-10 14:59:23 UTC
George, do you expect to have time to work on this or do you need help?
Send a patch to the list and we can help you optimize it.
Comment 5 Randy MacLeod 2024-01-18 16:29:26 UTC
Unassigning. George, take it back if you find time...
Comment 6 Dixit Parmar 2025-01-27 10:39:19 UTC
Hi, is anybody working on this? If not, I would like to work.
Comment 7 Randy MacLeod 2025-01-27 15:00:48 UTC
Thanks Dixit. Please CC George if/when you send a patch.
Comment 8 Dixit Parmar 2025-02-20 09:33:25 UTC
Hi randy.macleod@windriver.com,
I have the patch ready with me. can you confirm, to which mailing list should I submit this? I see some patches are coming from OE-Core so.
Comment 9 Dixit Parmar 2025-02-21 05:40:00 UTC
Randy,
FYI The changes are in <poky>/meta/classes-recipe/kernel-module-split.bbclass file.
Comment 10 Randy MacLeod 2025-02-21 14:40:36 UTC
Hi Dixit,

For changes to meta/classes-recipe/kernel-module-split.bbclass 
the right list is:
   openembedded-core@lists.openembedded.org

FYI, we do try to document this sort of thing:
   https://docs.yoctoproject.org/contributor-guide/index.html
specifically, the email list question is discussed here:
   https://docs.yoctoproject.org/contributor-guide/submit-changes.html#finding-a-suitable-mailing-list

I know there's a long learning curve for YP so I'm happy to help as well.
../Randy
Comment 11 Dixit Parmar 2025-02-22 07:17:21 UTC
Hi Randy,
Thanks for directing me to the resources. I have just started out on YP so naive questions. However I shall be fine soon by generous support from you guys.

Patch is submitted: https://lists.openembedded.org/g/openembedded-core/message/211817

I have added you in the CC George george.thopas@gmail.com.

Thanks,
Dixit
Comment 12 Randy MacLeod 2025-06-05 21:05:08 UTC
New version on the list today:

https://lore.kernel.org/openembedded-core/20250605131235.366013-1-dixitparmar19@gmail.com/
Comment 13 Dixit Parmar 2025-06-23 09:15:17 UTC
Patch is merged to master https://git.yoctoproject.org/poky/commit/?id=7f9f608d39cd11fb3d3da7b6c9ec5f447ed45745