Bug 15150 - runqemu calls runqemu-ifup with an incorrect number of arguments
Summary: runqemu calls runqemu-ifup with an incorrect number of arguments
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: Scripts and Tools (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Undecided normal
Target Milestone: 0.0.0
Assignee: Alejandro
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2023-06-21 00:26 UTC by Alejandro
Modified: 2023-06-28 22:35 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro 2023-06-21 00:26:51 UTC
The runqemu script passes 3 arguments to the runqemu-ifup call here:

https://git.yoctoproject.org/poky/tree/scripts/runqemu#n1185

However, since https://git.yoctoproject.org/poky/commit/?id=51063c1e6ac214b4ef43c88c8091c909a7cab2cb the runqemu-ifup script exits with '1' when not using 2 exactly arguments in the call.
Comment 2 Richard Purdie 2023-06-21 09:21:53 UTC
Thanks for the patch!
Comment 3 Adrian 2023-06-23 06:24:24 UTC
I guess since https://git.yoctoproject.org/poky/commit/?id=51063c1e6ac214b4ef43c88c8091c909a7cab2cb there more issues. I tried to fix them here: https://lists.openembedded.org/g/openembedded-core/message/183277.

But when reading this bug and looking at https://git.yoctoproject.org/poky/commit/?id=f9d22f26346564e1033539d6b4eb99d1ff280b85 I missed to send a patch to remove the uid paramter as well.
Comment 4 Richard Purdie 2023-06-28 22:35:32 UTC
(In reply to Adrian from comment #3)
> I guess since
> https://git.yoctoproject.org/poky/commit/
> ?id=51063c1e6ac214b4ef43c88c8091c909a7cab2cb there more issues. I tried to
> fix them here:
> https://lists.openembedded.org/g/openembedded-core/message/183277.
> 
> But when reading this bug and looking at
> https://git.yoctoproject.org/poky/commit/
> ?id=f9d22f26346564e1033539d6b4eb99d1ff280b85 I missed to send a patch to
> remove the uid paramter as well.

Thanks, we definitely weren't done with the fixes. Hopefully we're there now! Cleaning up and simplifying this is good in the long run!