Bug 15229 - meta-yocto-bsp/conf/machine/beaglebone-yocto.conf: MACHINE_EXTRA_RRECOMMENDS
Summary: meta-yocto-bsp/conf/machine/beaglebone-yocto.conf: MACHINE_EXTRA_RRECOMMENDS
Status: RESOLVED FIXED
Alias: None
Product: BSPs
Classification: Build System, Metadata & Runtime
Component: bsps-meta-yocto (show other bugs)
Version: 4.2.4
Hardware: x86 Multiple
: Medium normal
Target Milestone: 5.1
Assignee: Kevin Hao
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2023-10-11 07:23 UTC by Robert Berger
Modified: 2024-09-27 01:20 UTC (History)
1 user (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Berger 2023-10-11 07:23:26 UTC
Here[1] both:

MACHINE_EXTRA_RRECOMMENDS = "kernel-modules kernel-devicetree"

and

MACHINE_ESSENTIAL_EXTRA_RDEPENDS += "kernel-image kernel-devicetree"

are defined.

I would say that MACHINE_ESSENTIAL_EXTRA_RDEPENDS wins, so does it make any sense to define both?

[1] https://git.yoctoproject.org/poky/tree/meta-yocto-bsp/conf/machine/beaglebone-yocto.conf
Comment 1 Kevin Hao 2023-10-11 13:53:13 UTC
It makes no sense to put 'kernel-devicetree' into both MACHINE_EXTRA_RRECOMMENDS and MACHINE_ESSENTIAL_EXTRA_RDEPENDS. I can make a patch to drop it from MACHINE_EXTRA_RRECOMMENDS. 

But since the 'kernel-modules' is not essential for booting the machine, it should be set in MACHINE_EXTRA_RRECOMMENDS. And the 'kernel-image' and 'kernel-devicetree' are essential for the machine to boot and should be set in MACHINE_ESSENTIAL_EXTRA_RDEPENDS.
Comment 2 Robert Berger 2023-10-12 08:04:01 UTC
What if you want to build a small image like a core-image-minimal and would like to have kernel-modules inside?

With MACHINE_EXTRA_RRECOMMENDS = "kernel-modules kernel-devicetree"

they will not be added, but with MACHINE_ESSENTIAL_EXTRA_RDEPENDS they will be added.

What would you suggest?
Comment 3 Kevin Hao 2023-10-12 12:53:07 UTC
The 'kernel-modules' is not essential for booting the machine, so it is set in the MACHINE_EXTRA_RRECOMMENDS. This is consistent with all other machines (qemus, genericx86). We can't includes all the packages in core-image-minimal image.

If you indeed want to include the 'kernel-modules' in your core-image-minimal image, you should modify your conf/local.conf by adding 'IMAGE_INSTALL:append = "kernel-modules".
Comment 4 Randy MacLeod 2023-10-12 14:43:31 UTC
Robert, does Kevin's explanation help.
Comment 5 Robert Berger 2023-10-13 06:52:25 UTC
Yes, this explanation helps.
Thanks!
Comment 6 Randy MacLeod 2023-10-19 15:01:40 UTC
Robert, it seems you got the info you need so I'm closing the bug.
Comment 7 Robert Berger 2023-10-24 10:27:29 UTC
I guess Kevin should make a patch as indicated above:

"It makes no sense to put 'kernel-devicetree' into both MACHINE_EXTRA_RRECOMMENDS and MACHINE_ESSENTIAL_EXTRA_RDEPENDS. I can make a patch to drop it from MACHINE_EXTRA_RRECOMMENDS. 
"
Comment 8 Robert Berger 2024-05-23 06:39:48 UTC
this seems to be fixed

commit 97306ebc00ef3dd7eacab817659d980c29da96ea
Author: Kevin Hao <kexin.hao@windriver.com>
Date:   Tue Jan 2 19:57:08 2024 +0800

    beaglebone-yocto: Remove the redundant kernel-devicetree
    
    The kernel-devicetree is set in both MACHINE_ESSENTIAL_EXTRA_RDEPENDS
    and MACHINE_EXTRA_RRECOMMENDS. Since it is an essential package for
    boot, drop the one in MACHINE_EXTRA_RRECOMMENDS.
    
    [YOCTO #15229]
    
    (From meta-yocto rev: 5935d4fd751153f0f1c930924a5e2771f6dd5e72)
    
    Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Comment 9 Robert Berger 2024-05-23 06:40:38 UTC
-MACHINE_EXTRA_RRECOMMENDS = "kernel-modules kernel-devicetree"
+MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
Comment 10 Randy MacLeod 2024-09-26 18:17:13 UTC
Kevin, any news or move to 5.2 ?
Comment 11 Kevin Hao 2024-09-27 01:20:45 UTC
This issue has already been fixed, so close it.