Bug 15601 - The image_qa task hides unexpected exceptions
Summary: The image_qa task hides unexpected exceptions
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 5.1
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 5.2 M1
Assignee: Peter Kjellerstedt
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2024-09-25 00:54 UTC by Peter Kjellerstedt
Modified: 2025-01-07 21:16 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Kjellerstedt 2024-09-25 00:54:39 UTC
After commit 905e224849fbbed1719e0add231b00e2d570b3b4 (image_qa: fix error handling), any unexpected exceptions in do_image_qa() would result in a variable being set, but never used, effectively hiding the error.

For Styhead, my recommendation is to just remove the catch of Exception and just let any unexpected exceptions pass on up.

For master I instead recommend that we remove the use of the ImageQAFailed exception (and all exception handling in do_image_qa), and instead rely on the called functions to call oe.qa.handle_error() themselves. This matches what do_package_qa() does.
Comment 1 Ross Burton 2024-09-26 15:58:34 UTC
Peter has sent patches.
Comment 2 Peter Kjellerstedt 2025-01-07 21:16:48 UTC
This was solved in commit 0c3e111c965af2bc56533633c376b70b7fa5e1de for master, and  commit c00ad42b6a26ceb7a2878ed2c7f6c2821fe513cc for Styhead.