It's not uncommon for people to put the Upstream-Status or Signed-off-by tags in patches _after_ the patch scissors ("---"), which means they get thrown away by git and so lost when devtool does a patch refresh. patchtest should detect this and tell the submitter to put the tags above the scissors.
I'm one of those people who put Upstream-Status after scissors (and migrated all LGE layers to use that), because unlike Signed-off-by this shouldn't be applied in the component repository and many people were applying the patches correctly with "git am", but not removing the Upstream-Status from commit message. After they merge it in component repo it's too late to remove it, but when it's removed by devtool it's easy to notice it missing when reviewing the devtool changes (or it's caught by QA check when Upstream-Status is missing).
I would like to work on this bug.
Aditya, Another week, another YP bug that you're working on ! ;-) Trevor will be your main contact for this bug so please CC him on the review. I think he's just getting back from a conference so he may not be online for a few days.
Hi Randy, Thanks for the guidance! There are multiple Trevor entries listed in Bugzilla. Could you please confirm that I should CC Trevor Gamblin <tgamblin@baylibre.com> on the patch submission? Also, thanks for the encouragement 🙂 I'm getting into a good rhythm working on these YP bugs week by week. I'll start working on the implementation and share a patch soon. Thanks, Aditya
Created attachment 5229 [details] patchtest: warn if Upstream-Status is after patch scissors Hi, I have implemented the requested change to warn instead of fail when Upstream-Status is placed after the patch scissors. Patch sent to the mailing list for review. Thanks, Aditya
Hi, Since the patch for this issue has been submitted and will take some time to go through the review process, I will be working on another bug in parallel to continue contributing and gaining experience. I will monitor the review and promptly address any feedback or required changes. Thanks, Aditya
Created attachment 5230 [details] Updated patch Hi, I have addressed the review feedback for this issue. The patch has been updated to fix the indentation problems raised in the previous version, while retaining the intended behavior of emitting a warning when Upstream-Status appears after the patch scissors. A v3 of the patch has been sent to the mailing list for review, with Trevor Gamblin CC’d. I will monitor the mailing list and promptly address any further feedback. Thanks, Aditya
Hi, Thanks for the clarification on the mailing list. Based on the recent discussion, I now understand that the behavior in oe-core is intended to remain a hard failure, and that my earlier interpretation of this bug was incorrect. The functionality requested here was already implemented in oe-core in commit 2156ef9e6def (“patchtest: reject Upstream-Status after scissors”), and the Bugzilla entry was simply never closed, which led to the confusion. Since oe-core should continue rejecting patches that place Upstream-Status after the scissors, I have withdrawn my patch series that attempted to downgrade this check to a warning. Layers that intentionally place this tag after the scissors can disable or override this specific test in their own patchtest configuration, but for oe-core the current behavior is correct. Please let me know if I should mark this bug as RESOLVED/FIXED, or if maintainers prefer to close it themselves. Thanks, Aditya
https://git.openembedded.org/openembedded-core/commit/?id=2156ef9e6defa3ec9087789fcea25fb4fee7b83c Thanks Luka!