Bug 1669 - emenlow: glxgears running slowly on 3.0 kernel
Summary: emenlow: glxgears running slowly on 3.0 kernel
Status: RESOLVED FIXED
Alias: None
Product: BSPs
Classification: Build System, Metadata & Runtime
Component: bsps-configuration (show other bugs)
Version: 1.2
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.2 M4
Assignee: Tom Zanussi
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2011-10-11 17:04 UTC by Tom Zanussi
Modified: 2012-04-26 20:53 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Zanussi 2011-10-11 17:04:59 UTC 
When moving to 3.0, the drm ioctls in the psb driver were put under a drm mutex upon removal of the BKL.  The ones that did their own locking were given a DRM_UNLOCKED flag to avoid the redundant locking.  This locking is apparently the cause of the jerkinness and slowdown seen running glxgears, and I believe I've isolated it to the drm_lock and drm_unlock ioctl calls.  Giving them the DRM_UNLOCKED flag makes the problem disappear, but they need to be audited to determine if that's really safe to do.
Comment 1 Bruce Ashfield 2011-11-01 08:06:45 UTC 
Tom: was the intention to assign this to yourself ? I'm doing that now, but correct me if I'm wrong.
Comment 2 Tom Zanussi 2011-11-01 08:09:05 UTC 
(In reply to comment #1)
> Tom: was the intention to assign this to yourself ? I'm doing that now, but
> correct me if I'm wrong.

Yeah, that was the intention, thanks for doing it.
Comment 3 Jessica 2012-04-04 16:15:43 UTC 
Tom, this bug hasn't been updated for quite some time, can you please provide some update.  Also, should we move it to 1.3? thx
Comment 4 Tom Zanussi 2012-04-04 18:26:32 UTC 
(In reply to comment #3)
> Tom, this bug hasn't been updated for quite some time, can you please provide
> some update.  Also, should we move it to 1.3? thx

Yes, I actually started looking at this again last week, but haven't been able to really get into it due to conferences, etc.   Once I'm able to get back into development mode again next week, I'll be looking at this again pretty quickly into that.

It is something I plan to work on for 1.2, so it should stay there.
Comment 5 Tom Zanussi 2012-04-10 14:49:30 UTC 
This is BSP-specific i.e. to the emenlow branch of the kernel.