Bug 1913 - need to abstract building msdos images into an msdosfs.bbclass to share the code
Summary: need to abstract building msdos images into an msdosfs.bbclass to share the code
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: deployment (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Low minor
Target Milestone: 1.5
Assignee: Darren Hart
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks: 4778
  Show dependency tree
 
Reported: 2012-01-17 23:16 UTC by Dexuan Cui
Modified: 2013-09-20 16:15 UTC (History)
7 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dexuan Cui 2012-01-17 23:16:13 UTC 
Recently Darren sent a patch to fix the calculation of FAT filesystem overhead in image size:
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=1cabda965d0ec7c76f2fe57ce751154b9fc5e500

Actually meta/classes/boot-directdisk.bbclass has the same issue since it uses mkdosfs, too. So we need to fix boot-directdisk.bbclass, too.

To avoid duplicating the code (e.g., the the fatfs overhead calculations), we'd better create a new file msdosfs.bbclass that holds the common code so that bootimg.bbclass and boot-directdisk.bbclass can share that.
Comment 1 Darren Hart 2013-09-20 16:15:40 UTC 
commit c78c1f9c92a2c2b38699a732ad893b669ccefcda
Author: Jason Wessel <jason.wessel@windriver.com>
Date:   Sat Sep 14 00:08:57 2013 +0000

    bootimage.bbclass: Move fat image creation into a function