Bug 2326 - [Hob2] All 'Image details' screens must contain a primary action
Summary: [Hob2] All 'Image details' screens must contain a primary action
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 1.3 M1
Assignee: anliming
QA Contact:
URL:
Whiteboard: (P1)(QA Testing Completed)
Depends on:
Blocks:
 
Reported: 2012-04-18 08:53 UTC by Belen Barros Pena
Modified: 2012-10-17 07:57 UTC (History)
8 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---

Attachments
An 'Image details' screen without a primary action looks strange (67.97 KB, image/png)
2012-04-18 08:53 UTC, Belen Barros Pena 		no flags Details
A different example of 'Image details' screen with no primary action (394.12 KB, image/png)
2012-04-18 08:53 UTC, Belen Barros Pena 		no flags Details
noprimaryaction.png (38.40 KB, image/png)
2012-05-14 11:28 UTC, Belen Barros Pena 		no flags Details
no-primary-action-17May2012.png (59.13 KB, image/png)
2012-05-17 14:01 UTC, Belen Barros Pena 		no flags Details
no-primary-action-25May.png (40.27 KB, image/png)
2012-05-25 10:45 UTC, Belen Barros Pena 		no flags Details
no-primary-action-29May.png (40.26 KB, image/png)
2012-05-29 13:16 UTC, Belen Barros Pena 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2012-04-18 08:53:23 UTC 
Created attachment 488 [details]
An 'Image details' screen without a primary action looks strange

The rules should be as follows:

IF no primary action exists AND 'Save as template' exists THEN make 'Save as template' the primary action

IF no primary action exists AND 'Save as template' does not exists THEN make 'Build new image' the primary action
Comment 1 Belen Barros Pena 2012-04-18 08:53:57 UTC 
Created attachment 489 [details]
A different example of 'Image details' screen with no primary action
Comment 2 anliming 2012-05-10 09:12:23 UTC 
Hi Belen, the primary action of the 'my image' and 'build detail image' pages had been fixed as below with this patch (http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=6841abd17268a1c1ca5e3634f0ae9e21426ca9c9), please to reivew:

'my image' has three primary action, 'running image' -- supported images with the 'qemu..' type, 'deploy image' -- supported images with not 'qemu..' type, and the constaintly primary action 'build new image', user can't open the image we don't supported, and in 'my image' page user can't allow to selected the tar package, so no need to care this case.
'build detail image' page only show the latest build successful image and corresponding tar package, and it has four primary actions, 'running image','deploy image' ,'build new image' and 'Save as template', user can't select related tar package as similarly.
Comment 3 anliming 2012-05-11 03:16:44 UTC 
above patch I listed, I think it cover this bug.
Comment 4 Belen Barros Pena 2012-05-14 11:28:35 UTC 
Created attachment 508 [details]
noprimaryaction.png

Hi Liming, 

Has the patch you mention been merged to the master branch? I can still find examples of screens with no primary actions (see attachment called noprimaryaction.png)

Thanks!

Belen
Comment 5 Belen Barros Pena 2012-05-17 14:01:45 UTC 
Created attachment 517 [details]
no-primary-action-17May2012.png

Hi Liming,

This is not fixed, I'm afraid :(

Have a look at the attachment called no-primary-action-17May2012.png

I've built an image for atom-pc. The output does not include a live image, so the deploy button does not display. According to the principles outlined in the bug, 'Save as template' should have become the primary action on the screen.

Let me know if you have any questions. 

Cheers

Belen
Comment 6 Belen Barros Pena 2012-05-17 14:02:34 UTC 
Explanation of why I am reopening the file in the previous comment.
Comment 8 Belen Barros Pena 2012-05-25 10:45:56 UTC 
Created attachment 536 [details]
no-primary-action-25May.png

Sorry, Liming: still not fixed. See attached file 'no-primary-action-25may.png'

This screen should follow this rules: IF no primary action exists AND 'Save as template' does not exists THEN make 'Build new image' the primary action

This means that 'Build new image' should be on the right hand side of the screen and should be orange.

Let me know if you have any questions.

Belen
Comment 9 anliming 2012-05-28 12:43:33 UTC 
Hi Belen, I had added a new patch for this issue, please to review.http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=limx/hob-bug-fixes-continue
Comment 10 Belen Barros Pena 2012-05-29 13:16:24 UTC 
Created attachment 552 [details]
no-primary-action-29May.png

Sorry, Liming: still not fixed (see no-primary-action-29May.png)
Comment 11 Belen Barros Pena 2012-05-29 13:25:20 UTC 
Sorry, Liming:  my mistake. This is now fixed :)

Once the patch is merged I'll verify it.

Thanks!

Belen

(In reply to comment #10)
> Created attachment 552 [details]
> no-primary-action-29May.png
> 
> Sorry, Liming: still not fixed (see no-primary-action-29May.png)
Comment 12 Jiajun Xu 2012-06-12 07:44:35 UTC 
Verify the bug as fixed in QA testing.
Comment 13 Andreea Brandusa Proca 2012-10-17 07:57:35 UTC 
Verified in commit: c9de24d3f4845251b01e2eab0aeeb7472badc5bb.
Branch: danny.