Bug 3044 - [Autobuilder] Eclipse plugin build fails due to unsupported Override annotations in openjdk-7
Summary: [Autobuilder] Eclipse plugin build fails due to unsupported Override annotati...
Status: VERIFIED FIXED
Alias: None
Product: AutoBuilder
Classification: Infrastructure
Component: autobuilder (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.3 M4
Assignee: Michael Halstead
QA Contact:
URL:
Whiteboard: (autobuilder)
Depends on:
Blocks:
 
Reported: 2012-08-30 09:00 UTC by Ioana Grigoropol
Modified: 2012-09-25 12:08 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ioana Grigoropol 2012-08-30 09:00:36 UTC
It seems that the Autobuilder uses openjdk-7 for building the eclipse-plugin. 
In the latest changes submitted to master, 'Override' annotations were used for implementing methods from an interface. 
According to openjdk documentation, this was not supported in openjdk-5, but supported in 6, and 7. 
From my local tests, this is still an issue with 1.7 (the compilers still complains about annotations used for interfaces rather than classes).

My guess is the autobuilder should either use Oracle JDK 1.7, or check if there is a system constraint that force it to use openjdk-5.
Comment 1 Saul Wold 2012-08-30 14:28:26 UTC
Build machines need to have upgraded JDK installed.
Comment 2 Ross Burton 2012-08-30 14:32:19 UTC
I had a thought that maybe it's an option to the latest JDK, but I've been out of the loop on java since about 2002.
Comment 3 Michael Halstead 2012-08-31 17:36:47 UTC
I've installed Oracle JDK 1.7 on the public build slaves and made it the default implementation. Please report back if this corrects the issue or not.
Comment 4 Michael Halstead 2012-08-31 17:37:37 UTC
I've installed Oracle JDK 1.7 on the public build slaves and made it the default implementation. Please report back if this corrects the issue or not.
Comment 5 Michael Halstead 2012-08-31 22:40:37 UTC
The eclipse plugin is actually built on the master so this change didn't have any effect. I have installed OpenJDK 1.7.0u5 on ab01 for now and am working on adding the supplimental package channel for the OracleJDK.
Comment 6 Ioana Grigoropol 2012-09-05 11:41:57 UTC
My assumption that the system used a older version of the JDK was wrong, in fact the headless build for eclipse-plugin uses a some local settings (build.properties) that limit the system JDK to 1.5 for source compilation (regardless of system installation).
Sent a patch with this modification.
Comment 7 Laurentiu Serban 2012-09-25 12:08:30 UTC
Verified in commit id 8b3aa00029e62df6d05710cf166fd5d09bdb29cf