Bug 3082 - Hob should update bblayers.conf when required, instead of showing an error message
Summary: Hob should update bblayers.conf when required, instead of showing an error me...
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 1.3 M5
Assignee: Constantin Musca
QA Contact:
URL:
Whiteboard: cbddb898c2dc6fe78780dfc337f9d3aad9205...
Depends on:
Blocks: 3147
  Show dependency tree
 
Reported: 2012-09-10 09:50 UTC by Belen Barros Pena
Modified: 2012-10-09 13:51 UTC (History)
7 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments
bblayers_conf_hob_error.png (73.23 KB, image/png)
2012-09-10 09:50 UTC, Belen Barros Pena
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2012-09-10 09:50:16 UTC
Created attachment 776 [details]
bblayers_conf_hob_error.png

When my bblayers.conf file gets out of sync, Hob shows me an error message that tries to tell me how to fix it (see attached file bblayers_conf_hob_error.png). 

For someone like me, who knows nothing about the internal workings of bitbake, this error message doesn't help much. If my bblayers.conf file is out of sync, Hob should very smartly update it as required, bringing in the updates while keeping any manual changes I might have made to the file.
Comment 1 Paul Eggleton 2012-09-10 09:56:36 UTC
I think the nature of bblayers.conf is such that we could without too much difficulty update it automatically based on the current and target LCONF_VERSION values. We made two version-increasing changes to this file for the upcoming release so it seems worthwhile to implement something to do this automatically.
Comment 2 Alexandru Damian 2012-09-25 09:00:03 UTC
I propose to drop this bug from 1.3 M5.

It seems to be quite invasive and not easily done automatically - lots of corner cases, needs maintaining from version to version, etc.

Hob should help by automatically launch the meld command if meld is installed.



IMHO, this is a bug that need to be fixed in bitbake and not in HOB
Comment 3 Paul Eggleton 2012-09-25 09:28:44 UTC
The actual code to do the updating is really not that complicated, and we don't change this file that often. The difficult part is where to launch the update from. To keep things simple for this release I have proposed to put the code in sanity.bbclass (since it has to be in the metadata and not in bitbake) and then exit when the update has been done, telling the user they need to restart. It would be better if we could re-read the configuration but that is something we can address in 1.4.

The problems with launching meld are (a) most users of hob won't have it installed, and (b) they won't know what to do when presented with a diff between their current file and the template. We have to do better than this, and luckily we can without too much trouble.
Comment 4 Constantin Musca 2012-09-26 10:31:54 UTC
(In reply to comment #2)
> I propose to drop this bug from 1.3 M5.
> 
> It seems to be quite invasive and not easily done automatically - lots of
> corner cases, needs maintaining from version to version, etc.
> 
> Hob should help by automatically launch the meld command if meld is
> installed.
> 
> 
> 
> IMHO, this is a bug that need to be fixed in bitbake and not in HOB

After talking to Paul, we have decided to put the bblayers.conf merging code into the sanity bbclass. Also, the specific meta-yocto bblayers.conf upgrades are done in another bbclass (poky-sanity). We only do the v4 -> v5 and v5 -> v6 upgrades because these are important for this release.

Constantin
Comment 5 Constantin Musca 2012-10-03 12:41:50 UTC
The solution automatically updates bblayers.conf telling the user to re-run afterwards. Please open a 1.4 bug for re-reading the configuration.

Constantin
Comment 6 Belen Barros Pena 2012-10-03 13:59:26 UTC
Marking as verified. I am opening a new bug with milestone 1.4 to make sure we address this issue without popping alerts or having to relaunch Hob.
Comment 7 Alexandru Georgescu 2012-10-09 13:14:45 UTC
(In reply to comment #6)
> Marking as verified. I am opening a new bug with milestone 1.4 to make sure
> we address this issue without popping alerts or having to relaunch Hob.

Hi Belen,
Can you add a comment with the bug id? 
After that I think it's okay to change the status of this bug to Verified Fixed.

Thanks,
Alex.
Comment 8 Belen Barros Pena 2012-10-09 13:51:37 UTC
Sorry, Alex: I should have marked this as verified when I open the bug, which is

https://bugzilla.yoctoproject.org/show_bug.cgi?id=3213

(In reply to comment #7)
> (In reply to comment #6)
> > Marking as verified. I am opening a new bug with milestone 1.4 to make sure
> > we address this issue without popping alerts or having to relaunch Hob.
> 
> Hi Belen,
> Can you add a comment with the bug id? 
> After that I think it's okay to change the status of this bug to Verified
> Fixed.
> 
> Thanks,
> Alex.