Bug 3108 - Packages are shown as brought in by 'User selected' when I've made no changes to the recipes in the base image
Summary: Packages are shown as brought in by 'User selected' when I've made no changes...
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 1.3 M5
Assignee: Constantin Musca
QA Contact:
URL:
Whiteboard: a2783d2f644b6e7704439380df0884c5351bc190
Depends on:
Blocks:
 
Reported: 2012-09-13 15:12 UTC by Belen Barros Pena
Modified: 2012-10-02 13:41 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---

Attachments
sysvinit showing as 'user selected' (94.83 KB, image/png)
2012-09-13 15:12 UTC, Belen Barros Pena 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2012-09-13 15:12:01 UTC 
Created attachment 800 [details]
sysvinit showing as 'user selected'

Steps to reproduce:

1. Launch Hob
2. Select atom-pc as your machine and core-image-minimal as your base image
3. Click the 'edit image' button
4. Without making any changes to the recipes, click the 'build packages' button
5. In the 'Edit packages' screen, click on 'sysvinit' to display the 'brought in by' information

Outcome: the package appears as 'User selected', but I have not selected anything myself since I made no changes to the recipes before building the packages. 3 or 4 other packages on the table also appear as 'User selected'. I've attached a screenshot.

I might be missing something here, but I don't think these packages should be shown as 'Use selected'.
Comment 1 Constantin Musca 2012-09-26 09:08:06 UTC 
You have selected an image which includes that package (that's why the package appears as "User selected").

Constantin
Comment 2 Belen Barros Pena 2012-09-27 14:10:28 UTC 
mmm, I don't think your comment makes sense. As per your argument, all recipes and packages should appear as 'user selected' (because all of them come from the base image I selected), but they don't. For example, in the list of packages you get when you build a core-image-minimal for atom-pc, eglibc is not listed as user selected. 

The fact that only a few packages on the list appear as 'user selected' seems to indicate something funny going on. 

(In reply to comment #1)
> You have selected an image which includes that package (that's why the
> package appears as "User selected").
> 
> Constantin
Comment 3 Belen Barros Pena 2012-10-01 10:00:32 UTC 
Constantin mentioned the following question over IM: "What happens if the user selects a package which is already brought in by another package? Should the 'User selected' text appear in "Brought in by"?"

In my opinion, if the package is already brought in by some other package, it should not appear as 'user selected', but this is from my limited understanding of things. Does anybody disagree with this approach?

Thanks!
Comment 4 Constantin Musca 2012-10-02 11:45:46 UTC 
Bug fixed.

Changes:
- the 'User selected' tag is only used when the user selects a package
- fix hob to remember which packages are 'User selected'
- if the package is already brought in by some other package, it should not appear as 'User selected'
Comment 5 Belen Barros Pena 2012-10-02 13:41:35 UTC 
verified