Bug 3167 - perf: annotate doesn't work
Summary: perf: annotate doesn't work
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: kernel (show other bugs)
Version: 1.3
Hardware: x86 Multiple
: Medium+ normal
Target Milestone: 1.3
Assignee: Tom Zanussi
QA Contact:
URL:
Whiteboard: Done
Depends on:
Blocks:
 
Reported: 2012-09-25 02:35 UTC by Tom Zanussi
Modified: 2012-10-08 18:05 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Zanussi 2012-09-25 02:35:44 UTC
Invoking perf annotate fails with the runtime errof 'expand: command not found'.

The annotate command is implemented using a command pipeline like "objdump ... -d %s %s -C %s|grep -v %s|expand", which should be installed as part of coreutils but isn't (e.g. on qemux86 core-image-sato).
Comment 1 Darren Hart 2012-09-27 14:43:35 UTC
Tom, what is the size increase to busybox by adding expand to the default build? This will determine if we can realistically do this for 1.3 or not.
Comment 2 Saul Wold 2012-09-27 21:02:50 UTC
The other options, which RP and I would pefer is to set the RDEPENDS for perf to either use bash or coreutils, which ever provides the "expand" command, that way we are not add space to busybox for a narrow usage.
Comment 3 Tom Zanussi 2012-09-27 22:36:28 UTC
Yeah, the functionality of expand seems too minimal to even have to pull coreutils in - I'll look into providing an alternative local fix to avoid having to pull expand in at all.
Comment 4 Darren Hart 2012-10-08 18:05:21 UTC
Fixed in master:

commit a08139b7acdc528f9f7a20e49402144c89b8eb2b
Author: Bruce Ashfield <bruce.ashfield@windriver.com>
Date:   Mon Oct 8 09:54:46 2012 -0400

    linux-yocto-bsps/3.4: perf: parallel build and tools fixes

commit df9800cf087af6bae832dc60a51051bff31bce87
Author: Bruce Ashfield <bruce.ashfield@windriver.com>
Date:   Mon Oct 8 09:49:38 2012 -0400

    linux-yocto/3.4: perf: parallel build and tools fixes