Bug 3200 - Refactor hig.py into individual components
Summary: Refactor hig.py into individual components
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: 1.4
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.4
Assignee: Bogdan Marinescu
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2012-10-01 10:19 UTC by Bogdan Marinescu
Modified: 2013-04-10 07:47 UTC (History)
8 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bogdan Marinescu 2012-10-01 10:19:44 UTC
Currently, bitbake/lib/bb/ui/crumbs/hig.py is a large conglomerate of various UI dialogs stuffed together in the same file that keeps on growing. Besides being wrong from a design standpoint, this is starting to lead to issues (failed git merges, for examples) and it's becoming a bit of a maintenance problem. I'd like to refactor this: make 'hig' a separate package in bitbake/lib/bb/ui/crumbs/hig/ and split the original hig.py into separate files for each of its classes. I already talked to Paul and he said that this should be OK as long as we schedule it for 1.4. 
Note that this is only an implementation-side change; it doesn't change functionality in any way, it just refactors existing code. It should however make Hob a bit more maintainable.
Comment 1 Bogdan Marinescu 2013-01-09 16:29:45 UTC
Almost ready to be uploaded.
Comment 2 Bogdan Marinescu 2013-01-10 11:21:30 UTC
Patch sent to bitbake-devel (hig.py: refactor into individual components)
Comment 3 Bogdan Marinescu 2013-01-22 09:22:00 UTC
Patch merged.
Comment 4 Andreea Brandusa Proca 2013-04-10 07:47:26 UTC
Verified in fe336b149552b1f4f24d979c40302653298b98cc.