60% into the recipe parsing process the 'Stop' button to the right of the progress bar becomes inactive. Something has prompted that change, but users are not told about it. We should use the progress bar text to indicate that Hob has gone from parsing recipes to "Generating dependency tree". That will at least provide some visibility of what has caused the 'Stop' button state to change.
patch merged to master
Hi Cristiana, Just had a look at this. I'm afraid I have a few comments ... as always ;). I'll list them here and we can then decide how to handle them: 1. Text format. The progress bar text sometimes has a semicolon after the string ("Parsing recipes:") and sometimes it doesn't ("Generating dependency tree"). It would be good to get rid of that semicolon everywhere. 2. At exactly 98%, the text of the progress bar changes back to "Parsing recipes:". To me this seems a bit strange: it's like Hob is going back to something it already did, which doesn't make much sense. 3. At 99% the progress bar displays "Populated recipes". I am not sure what this means. Is that 99% of the recipes have been populated? Or is that Hob is in the process of populating recipes? In any case, it seems to me we should display "Populating recipes", since this is the format we use in all other strings (parsing recipes, generating tree). 4. I didn't see it coming, but the % now looks strange to me. Basically, Hob is telling me about all the different things it is doing, while showing me a single percentage as if it was doing just one thing. I've had a quick look to the Gnome HIG, which has a section in progress bars (http://developer.gnome.org/hig-book/3.5/controls-progress-bars.html.en) and none of them recommends showing progress with a percentage. What's more, in their section about progress windows (http://developer.gnome.org/hig-book/3.5/windows-progress.html.en) they sort of discourage the use of %: 'It is better to provide specific information rather than a unitless percentage. For example, "13 of 19 images rotated" or "12.1 of 30 MB downloaded" rather than "13% complete".' We could move the text outside the progress bar (that would probably help), but I am wondering if we shouldn't just get rid of the % altogether, since it is not very informative (you can already get a sense of the progress from the movement of the progress bar) and it does not reflect how much time is left until the process is complete. What do you think? I can file separate bugs for all the above: just let me know what works best for you. Thanks! Belen
I will reopen this bug because all those issue have the same subject. Now I'm working to fix something else, but these days I will fix this too. Thank you! (In reply to comment #2) > Hi Cristiana, > > Just had a look at this. I'm afraid I have a few comments ... as always ;). > I'll list them here and we can then decide how to handle them: > > 1. Text format. The progress bar text sometimes has a semicolon after the > string ("Parsing recipes:") and sometimes it doesn't ("Generating dependency > tree"). It would be good to get rid of that semicolon everywhere. > > 2. At exactly 98%, the text of the progress bar changes back to "Parsing > recipes:". To me this seems a bit strange: it's like Hob is going back to > something it already did, which doesn't make much sense. > > 3. At 99% the progress bar displays "Populated recipes". I am not sure what > this means. Is that 99% of the recipes have been populated? Or is that Hob > is in the process of populating recipes? In any case, it seems to me we > should display "Populating recipes", since this is the format we use in all > other strings (parsing recipes, generating tree). > > 4. I didn't see it coming, but the % now looks strange to me. Basically, Hob > is telling me about all the different things it is doing, while showing me a > single percentage as if it was doing just one thing. I've had a quick look > to the Gnome HIG, which has a section in progress bars > (http://developer.gnome.org/hig-book/3.5/controls-progress-bars.html.en) and > none of them recommends showing progress with a percentage. What's more, in > their section about progress windows > (http://developer.gnome.org/hig-book/3.5/windows-progress.html.en) they sort > of discourage the use of %: 'It is better to provide specific information > rather than a unitless percentage. For example, "13 of 19 images rotated" or > "12.1 of 30 MB downloaded" rather than "13% complete".' We could move the > text outside the progress bar (that would probably help), but I am wondering > if we shouldn't just get rid of the % altogether, since it is not very > informative (you can already get a sense of the progress from the movement > of the progress bar) and it does not reflect how much time is left until the > process is complete. What do you think? > > I can file separate bugs for all the above: just let me know what works best > for you. > > Thanks! > > Belen
Hello Belen, I forgot to say that I agree with you. So i will removed the % everywhere here (also semicolon). I will change also the text(to finish in "ing"). Thank you for your advices!
Thanks! :) (In reply to comment #4) > Hello Belen, > I forgot to say that I agree with you. So i will removed the % everywhere > here (also semicolon). I will change also the text(to finish in "ing"). > > Thank you for your advices!
merged to master commit : 99fa251b5696dff77358d514175bbb08802a7a02
Verified on 41125ddc8651494ffcf888d3b5efce1ae6d953bb