Bug 3352 - Improve smart error/status reporting
Summary: Improve smart error/status reporting
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 1.4
Hardware: All Multiple
: Medium+ enhancement
Target Milestone: 1.4 M5
Assignee: Bogdan Marinescu
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2012-10-29 17:21 UTC by Paul Eggleton
Modified: 2013-03-21 14:13 UTC (History)
8 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Eggleton 2012-10-29 17:21:12 UTC
The smart utility's output leaves something to be desired. For example:

* smart doesn't seem to produce an error on invalid use of commands e.g. smart config name=value (should be smart config --set name=value in this case)
* --log-level=debug doesn't seem to actually print any additional information
* Blank lines seem to be printed a lot when ideally the output would be a bit more compact

This is a little open-ended and probably will involve some cooperation with upstream. We can sit down and document more of the undesirable reporting situations first if needed.

(This is less important than the rest of the smart work however and should not hold that back.)
Comment 1 Bogdan Marinescu 2012-12-18 08:56:11 UTC
I uploaded a patch that addresses the first of the issues mentioned by Paul. The second one needs a bit of discussion. What kind of additional information would be needed in this case? I don't want to add too much information in the output.
Comment 2 Bogdan Marinescu 2013-01-22 14:39:40 UTC
Swithing to NEEDINFO (see my previous question).
Comment 3 Paul Eggleton 2013-01-23 14:24:44 UTC
It's hard to specify exactly what should be in the debug output, but a very good start would be to ensure RPM's own debugging output gets printed when --log-level=debug is specified.
Comment 4 Jessica 2013-02-14 15:57:47 UTC
Bogdan,

Please see Paul's last comments
Comment 5 Bogdan Marinescu 2013-03-05 12:28:23 UTC
The general consensus seems to be that this bug is already fixed and additional bugs should be opened for more improvements in the areas of error reporting/improved debug information, so I'm going to close this one.
Comment 6 Alexandru Palalau 2013-03-21 14:13:19 UTC
Verified on master branch.
Commit ID: a317cc911abe33d0f513d48e7bc4afd319c7e040