Bug 3529 - Package selection search is counter-intuitive
Summary: Package selection search is counter-intuitive
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: 1.4
Hardware: x86 Multiple
: Low normal
Target Milestone: 1.4
Assignee: Cristiana Voicu
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2012-12-04 09:39 UTC by Alexandru Damian
Modified: 2013-04-03 10:28 UTC (History)
8 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments
3529 - Table search.pdf (236.17 KB, application/pdf)
2013-02-05 17:55 UTC, Belen Barros Pena
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Damian 2012-12-04 09:39:39 UTC
In HOB / Edit Image / Package selection,


When the user starts typing letters, the current highlighted package will jump to the first package that has the name starting with the letters typed.

This is counter intuitive in the way searching in a multiple-selection list should work.



Expectation:

General UI expectations for searching a multiple-choice list will have the list narrowing down by eliminating the entries that do NOT match the typed letter sequence as a substring. See how Facebook search works.

E.g. typing ssh will not lead me to the "openssh" package. I would expect by typeing "ssh" I will get a list narrowed-down to the packages containing "ssh" in their name, for instance "openssh" but also "dropbearssh" if available.
Comment 1 Cristiana Voicu 2013-01-31 13:21:22 UTC
After talking with Belen, we have decided that we need a design for the case when there is no result for search. I will put this bug on needinfo.
Comment 2 Belen Barros Pena 2013-01-31 13:24:00 UTC
This bug needs design. There are a few things to think about:

- Which table columns are searched (all?)

- How do we present visually the search string on the results

- We need a "no results" state (i.e. what do we show when the search string entered does not match any content on the table). 

etc.

Working on it

Belen
Comment 3 Belen Barros Pena 2013-02-05 17:55:59 UTC
Created attachment 1059 [details]
3529 - Table search.pdf

Suggested design attached.
Comment 4 Cristiana Voicu 2013-03-01 15:35:00 UTC
Hello Belen,

As we spoke on chat, here you can find a branch with the implementation for this bug/enhancement:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=cvoicu/searchHob

I am waiting for your feedback.
Thanks,
Cristiana
Comment 5 Belen Barros Pena 2013-03-04 15:25:04 UTC
Cristiana, this is so cool! :) I agree with you: I don't think we need the search string highlight on the search results, and the inactive state of the 'clear' icon works fine.

There are a couple of tiny things to change. The biggest issue is the ordering of the results. I think the table items starting with the search string should display at the top, followed by the table items that contain the search string in any other position. Within these 2 groups, the results should be sorted alphabetically. What this means is that if I search for 'eg' in the 'All recipes' tab, I should see the results in this order:

1. eglibc
2. eglibc-initial
3. eglibc-locale
4. eglibc-mtrace
5. eglibc-scripts
6. jpeg
7. nativesdk-eglibc
8. nativesdk-eglibc-initial
9. nativesdk-eglibc-locale

There are 2 other small details:

- The hint text in the Search field should display whenever the field is empty and not on focus. If I enter a search string, then click the clear icon, then click on a table row to move the focus off the search field, the hint text does not show.

- In the 'no results' infobar, the 'Clear search' button has a tooltip that it's clearly not meant for it (it says: "edit the image parameters").

And that's it. If we get the above sorted out, you can submit the patch. This is really cool and incredibly useful functionality!

Belen


(In reply to comment #4)
> Hello Belen,
> 
> As we spoke on chat, here you can find a branch with the implementation for
> this bug/enhancement:
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=cvoicu/
> searchHob
> 
> I am waiting for your feedback.
> Thanks,
> Cristiana
Comment 6 Cristiana Voicu 2013-03-25 12:57:26 UTC
merged to master 
commit 860f826753cab81b1d1d9b2ecafa630a96676d9e
Comment 7 Andreea Brandusa Proca 2013-04-03 10:28:12 UTC
Verified in master:fd4e5c6c58183f1a017c6b5fe4d43c320e273567. 
For the result order was created another bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=4111.