Bug 3744 - PR Server variables could be more concise
Summary: PR Server variables could be more concise
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 1.4
Hardware: x86 Multiple
: Low enhancement
Target Milestone: 1.4
Assignee: Constantin Musca
QA Contact:
URL:
Whiteboard: 2f1aba504c592b5983d09e84cba71f86e8cea02a
Depends on:
Blocks:
 
Reported: 2013-01-17 11:46 UTC by Ross Burton
Modified: 2013-02-21 15:02 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Burton 2013-01-17 11:46:05 UTC 
Instead of PRSERV_HOST and PRSERV_PORT being two variables and undefined by default, how about merging them and having a sane default.

PRSERV_HOST could be of the form "hostname:port" (fairly standard practise), and default to "localhost:0". By making that a default, activating the PR server is just USE_PR_SERV=1.
Comment 1 Constantin Musca 2013-01-23 14:58:30 UTC 
We decided to eliminate USE_PR_SERV and use PRSERV_HOST = "hostname:port" for activating PRS (patches sent to the mailing lists).

Cheers,
Constantin
Comment 2 Constantin Musca 2013-01-30 07:47:50 UTC 
Patches merged. (last commit 2f1aba504c592b5983d09e84cba71f86e8cea02a)

Cheers,
Constantin
Comment 3 Stoicescu Cornel 2013-02-21 15:02:06 UTC 
Verified in master:7d22ef28e64de06b6238d0ef9b664c0bee6efa46