Bug 3812 - Bitbake event handlers recieve all events
Summary: Bitbake event handlers recieve all events
Status: VERIFIED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: 1.3
Hardware: x86 Multiple
: Medium+ enhancement
Target Milestone: 1.5 M4
Assignee: Cristiana Voicu
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks: 4142 4717
  Show dependency tree
 
Reported: 2013-01-30 16:00 UTC by Richard Purdie
Modified: 2013-09-11 11:41 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Purdie 2013-01-30 16:00:20 UTC
It would be better if events could select which events they would recieve with some kind of event mask. This could snigificnatly improve performance since currently we execute all event hanlders for all events.
Comment 1 Bogdan Marinescu 2013-05-31 14:35:08 UTC
A part of the fix for this issue was sent for review.
Comment 2 Cristiana Voicu 2013-06-19 10:09:40 UTC
Update: the patch which implements filtering only for class event handlers have been merged; commit: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=5aa5fc470ef20a3eda761d7dd8899732cb799ca4

ToDo: events filter for UIs, if needed (this needs to be analyzed)
Comment 3 Richard Purdie 2013-08-21 15:36:58 UTC
Cristiana: Are you working on this or not? 

I think we're going to need this to make BBSERVER=xxx bitbake yyy usable since its currently slow, likely due to all the debug messages.
Comment 4 Cristiana Voicu 2013-08-22 07:52:37 UTC
I have an implementation. It can be found at http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=cvoicu/fitleringeventsUi

It is almost done (if I am in the right direction), but I have an issue regarding some process; set_UIHmask is called in a process, and fire_ui_handlers in another. That's why _ui_handlers_map  is not populated yest in the second process. In the implementation I harcoded it in order to build an image. 
Can you please advice?
Thanks,
Cristiana
Comment 6 Stoicescu Cornel 2013-09-11 11:41:38 UTC
Verified in master:0ca5d1fb38157564a2b9452ade32391d18a41b09
using test case: https://bugzilla.yoctoproject.org/tr_show_case.cgi?case_id=806