Bug 395 - i915 options are ignored by configme (any choice marked as optional)
Summary: i915 options are ignored by configme (any choice marked as optional)
Status: VERIFIED FIXED
Alias: None
Product: Kernel
Classification: Yocto Project Subprojects
Component: kernel-tooling (show other bugs)
Version: 0.9
Hardware: x86 Multiple
: Medium normal
Target Milestone: 0.9 M4
Assignee: Darren Hart
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2010-10-04 13:44 UTC by Darren Hart
Modified: 2010-12-20 21:39 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified: Program Management
Documentation change: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darren Hart 2010-10-04 13:44:12 UTC
The configme script would force all choice sub-options to not set if the Kconfig choice is marked optional. This problem doesn't occur in mainline. I tracked the "fix" down to the following patch.

e66f25d7d1be19e177cf55126a40799757efae89
 Improve kconfig symbol hashing

While the fix appears to be an unintentional side-effect, the patch is small enough that it seems reasonable to pull it in.
Comment 2 Darren Hart 2010-10-04 20:55:53 UTC
(In reply to comment #1)
> http://git.pokylinux.org/cgit.cgi/poky/commit/?id=8e5c0841ea4e8ffa95c55f3094d78918e1f98d52

That isn't the right fix... either you got the wrong fix or commented on the wrong bug. :-)
Comment 3 Darren Hart 2010-10-21 20:09:33 UTC
Fixed in linux-wrs/standard by:

commit 0431115c9d720fee5bb105f6a7411efb4f851d26
Author: Andi Kleen <andi@firstfloor.org>
Date:   Wed Jan 13 17:02:44 2010 +0100

    Improve kconfig symbol hashing