scripts/contrib/mkefidisk.sh hardcodes 'rw' as root mount option, which breaks fsck which expects a 'ro' param to work.
When is fsck breaking? During a boot test? What would you like to see instead? An option to use 'rw', unilateral use of 'ro'?
you can't run fsck on a rw fs, I'd like to have an option to choose ro or rw, but just replacing rw with ro is fine by me as well
If this is just running it after boot.... why not just remount the fs? $ mount -o remount,ro /dev/sda2 / $ fsck /dev/sda2 This is what I've always done. It seems backwards to change the normal boot method and parameters so a debugging tool can be run without any setup....
well, you need to boot with 'ro' if you don't use an initramfs and want the builtin fsck to work, which it doesn't do right now. I realize that oe-core sysv scripts don't have any way to run fsck, but systemd does, and it has worked great for years now on other platforms (e.g. beagle*). I don't see why mkefidisk.sh needs to be special and force rw mode.
OK, that is why asked if it was part of boot or later. I'm fine adding the option to choose which to use.
commit 24cd3ddeb70a3d3f2985ec71c87ae0108f3d2777 Author: Darren Hart <dvhart@linux.intel.com> Date: Tue Mar 19 15:15:03 2013 -0700 mkefidisk: Boot with ro kernel parameter instead of rw