If a layer directory no longer exists in the location specified when the layer was added to the Layer's dialog, Hob complains. Currently, we display a generic error (see bug 3909). We would like to change this to a more specific error that helps users recover from the problem. A design suggestion is attached.
Created attachment 1172 [details] 4302 - Missing layer directory error.pdf
Hi Andrei, Thanks for sharing your dev branch. I've played with the fix a little bit, and wrote a few comments below: * If we cannot use the Hob primary window to display the error, let's use an alert window as specified by the Gnome HIG https://developer.gnome.org/hig-book/stable/windows-alert.html.en Spacing, positioning and layout guidelines are explained here: https://developer.gnome.org/hig-book/stable/windows-alert.html.en#alert-spacing * We are missing the button tooltips. They should say: "Remove $LAYER_NAME from you list of layers" for the 'Delete layer from list' button. "Select the new location of the $LAYER_NAME directory" for the 'Select new location' button. * I think we need a busy cursor after the user has taken action (i.e. after clicking the "Delete layer from list" button and after selecting the new location of the layer), to indicate that the instruction has been received and something is happening until the Hob primary window opens. * Could we match the style of the notifications (height, width, spacing, icon size, etc) to the one implemented for the image details screen to indicate the build is complete? Just for consistency. * The confirmation message after the layer has been deleted is missing a space between the layer name and the rest of the string. * Hob crashes if I click the "Cancel" button in the file selection dialog. I've attached a screenshot of the error displayed in the terminal window (see error-when-cancel.png) * When I click on the "Select new location" button, if I fail to select the right directory the first time (for example, I select a directory containing a different layer, not the missing one), but then I select the right directory the second time, Hob does not launch. If I launch Hob manually, it launches successfully with the missing layer listed in the new location. Le me know if you have any questions.
Created attachment 1199 [details] error-when-cancel.png
Pretty much all fixed. Only a few comments about that alert window. I've attached a screenshot of what I see :) (In reply to comment #2) > Hi Andrei, > > Thanks for sharing your dev branch. I've played with the fix a little bit, > and wrote a few comments below: > > * If we cannot use the Hob primary window to display the error, let's use an > alert window as specified by the Gnome HIG > > https://developer.gnome.org/hig-book/stable/windows-alert.html.en > > Spacing, positioning and layout guidelines are explained here: > > https://developer.gnome.org/hig-book/stable/windows-alert.html.en#alert- > spacing On the way there. Just a few issues: * The primary text needs to wrap when the length of the string overflows the alert width (see attached layers_alert_8May.png) * We need to change back the button labels as per the design document ("Delete layer from list" and "Select new location") * It would be good to trim the button width to better fit the labels. Both buttons should have the same width though. * The buttons are overlapping (see attached layers_alert_8May.png). We should set some white space between them (we can try 12px) * Alerts should have no window title (from the Gnome HIGs: Alert windows have no titles, as the title would usually unnecessarily duplicate the alert's primary text. This way, users can read and respond to alerts more quickly as there is less visual noise and confounding text.), so we should take it out. > > * We are missing the button tooltips. They should say: > > "Remove $LAYER_NAME from you list of layers" for the 'Delete layer from > list' button. > > "Select the new location of the $LAYER_NAME directory" for the 'Select new > location' button. Fixed. Thanks! > > * I think we need a busy cursor after the user has taken action (i.e. after > clicking the "Delete layer from list" button and after selecting the new > location of the layer), to indicate that the instruction has been received > and something is happening until the Hob primary window opens. I understand this is not possible. Thanks for taking the time to look into it! > > * Could we match the style of the notifications (height, width, spacing, > icon size, etc) to the one implemented for the image details screen to > indicate the build is complete? Just for consistency. Top and bottom padding look different, but I am not too bothered about this. > > * The confirmation message after the layer has been deleted is missing a > space between the layer name and the rest of the string. Fixed > > * Hob crashes if I click the "Cancel" button in the file selection dialog. > I've attached a screenshot of the error displayed in the terminal window > (see error-when-cancel.png) Fixed > > * When I click on the "Select new location" button, if I fail to select the > right directory the first time (for example, I select a directory containing > a different layer, not the missing one), but then I select the right > directory the second time, Hob does not launch. If I launch Hob manually, it > launches successfully with the missing layer listed in the new location. Fixed > > Le me know if you have any questions.
Created attachment 1209 [details] layers_alert_8May.png
Created attachment 1210 [details] icon-overlap.png Just found something else, I'm afraid. In the notification, the icon overlaps the beginning of the layer name when long.
I managed to fix what you suggested, but there seems to be a difference between your screenshot and what i have on my side. Probably because you are using fedora. I pushed a branch over here : http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=adinux/test I hope we will reach a common point, because the two spacing problems ( buttons and text ) on my side were looking ok. Please send me feedback on how everything is looking on your side. Thanks.
Moving to 1.6 as agreed with Valentin
Since it's a M+ an ETA would be helpful for the QA planning. Thanks!
Agreed with Belen that this will be WONTFIX