Bug 4342 - Apply a fade out animation when selecting / deselecting from tables when sorted by the "Included" column
Summary: Apply a fade out animation when selecting / deselecting from tables when sort...
Status: VERIFIED FIXED
Alias: None
Product: Hob
Classification: Build System, Metadata & Runtime
Component: hob (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 1.5 M1
Assignee: Cristiana Voicu
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2013-04-18 13:55 UTC by Belen Barros Pena
Modified: 2013-05-28 11:23 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2013-04-18 13:55:15 UTC
When you have the "All recipes", "All packages" and "Package groups" tables sorted by the "Included" column and you select / deselect something, the item you have selected / deselected changes position within the table due to the applied sorting. 

The effect is quite puzzling, since you can no longer see the item you just interacted with (generally it moves below or above the set of rows in view).

To provide some feedback as to what's happening, we could try a fading animation when you select / deselect something (as we do when you deselect something from the "Included recipes" and "Included packages" tables). I am not sure how well it'll work, but at least is a relatively straightforward solution we can try.
Comment 1 Belen Barros Pena 2013-04-18 13:57:22 UTC
assigning to Cristiana, since she was responsible for all the sorting-related work.
Comment 2 Cristiana Voicu 2013-04-29 10:17:14 UTC
Hi Belen,

As it is implemented the current fadeing animation for "Included recipes/packages", after you deselect something, the table will be sorted by recipe name, so it will lose the sorting column. Should we keep the same behaviour for the others tab? What I mean is that for e.g. in "All recipes" tab is it is sorted by Included, after you deselect an item , it would be selected by Name.
From the development point of view, it is easier to keep the same behaviour. Let me know your opinion.
Thanks!
Comment 3 Belen Barros Pena 2013-05-03 13:28:10 UTC
(In reply to comment #2)
> Hi Belen,
> 
> As it is implemented the current fadeing animation for "Included
> recipes/packages", after you deselect something, the table will be sorted by
> recipe name, so it will lose the sorting column. 

You are right: I hadn't notice that. I did see this functionality groups together at the top of the table all recipes / packages that will be removed: I guess it was done to give some visibility of what will be removed. But I don't understand why the sorting has to change after that.

Should we keep the same
> behaviour for the others tab? What I mean is that for e.g. in "All recipes"
> tab is it is sorted by Included, after you deselect an item , it would be
> selected by Name.
> From the development point of view, it is easier to keep the same behaviour.
> Let me know your opinion.

I don't think we should. When my table is sorted by other than 'Name', it's because I have expressly changed the sorting criteria. If Hob overrides my wishes every time I change something, I will probably end up quite annoyed with Hob ;)

Do you think we can extend the fix to the Included tabs, or should I open a (minor) bug?

Thanks!
Comment 4 Cristiana Voicu 2013-05-07 07:18:11 UTC
Hi Belen,

My opinion is to implement the fade out mechanism in the same way it is implemented in the other part, and then open a new bug to change its behaviour.
Sounds ok for you?
Cristiana
Comment 5 Belen Barros Pena 2013-05-07 09:46:49 UTC
(In reply to comment #4)
> Hi Belen,
> 
> My opinion is to implement the fade out mechanism in the same way it is
> implemented in the other part, and then open a new bug to change its
> behaviour.
> Sounds ok for you?

Sounds perfectly reasonable. Have opened bug 4453 with M3 milestone and assigned to you. Feel free to change milestone / assignee as needed.

Cheers

Belen

> Cristiana
Comment 7 Belen Barros Pena 2013-05-28 11:23:00 UTC
verified on 676fd3f394a0c0576b63c77ed2184bf5f42c29b6