Bug 4461 - bb.fatal() clean up
Summary: bb.fatal() clean up
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 1.5
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.5 M1
Assignee: Robert Yang
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2013-05-08 08:23 UTC by Robert Yang
Modified: 2013-06-04 06:23 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Yang 2013-05-08 08:23:14 UTC
The bb.fatal() is defined as:

def fatal(*args):
    logger.critical(''.join(args))
    sys.exit(1)

So anything after bb.fatal() in the same code block doesn't have any effect, e.g.:

    bb.fatal("%s_%s: %s" % (var, pkg, e))
    raise e

The "raise e" should be removed.
Comment 2 Ning Zhang 2013-06-04 06:23:45 UTC
Verified with poky (master:676fd3f394a0c0576b63c77ed2184bf5f42c29b6)

All same block code under bb.fatal() have been removed.