Bug 4905 - No proper location diagnostic for tab/space issues
Summary: No proper location diagnostic for tab/space issues
Status: RESOLVED WONTFIX
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.6
Assignee: Richard Purdie
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2013-07-25 07:03 UTC by Laszlo Papp
Modified: 2014-03-26 17:41 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Papp 2013-07-25 07:03:22 UTC
If you come from denzil to for instance dylan, you might get weird issues about tab/space as the enforcement was introduced in the meantime, perhaps even for good.

However, there are two issues in here:

1) You will get an error report for your recipe even if the error is inside the .inc required!

2) You will not get proper location, just a file name. It would need more fine tuning for better user experience.

I have been told the parser design is not prepared for it. That does not mean it should not be fixed. It just means that fixing the bad design might take longer.
Comment 1 Ross Burton 2013-07-25 08:00:10 UTC
(2) isn't true, you get a function name.  Generally the problem isn't specific to any particular line but the entire function.
Comment 2 Laszlo Papp 2013-07-25 08:14:03 UTC
I do not consider a function proper. Especially when code gets pasted from somewhere in a more fine-tuned manner than a function.

I do consider it true.
Comment 3 Richard Purdie 2014-03-26 17:41:21 UTC
The issue is that the function can consist of expanded data. We therefore can't check at the point the function is first created since it can be subsequently modified.

We do have variable tracking code however we default to not running with it since it has significant performance overhead. We therefore have to make a design choice between the usability aspect and performance.

The cases where people run into that error are comparatively rare, most people have migrated from denzil at this point. We therefore chose to keep the performance and won't be able to fix this issue any time soon.