Bug 5023 - EXTRA_IMAGE_FEATURES += "tools-sdk" does return ERROR
Summary: EXTRA_IMAGE_FEATURES += "tools-sdk" does return ERROR
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 1.5
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.8 M3
Assignee: Paul Eggleton
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks: 5052
  Show dependency tree
 
Reported: 2013-08-19 18:45 UTC by Daiane
Modified: 2015-02-03 17:46 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments
output for bitbake -e core-image-base (884 bytes, text/plain)
2013-08-20 00:41 UTC, Daiane
no flags Details
local.conf used to generate the ERROR (539 bytes, application/octet-stream)
2013-08-20 00:44 UTC, Daiane
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daiane 2013-08-19 18:45:42 UTC
I added EXTRA_IMAGE_FEATURES += "tools-sdk" to my local.cond and tried to build core-image-base. 

Please, see the ERROR:

$ ~/master/build$ bitbake core-image-base
Loading cache: 100% |####################################################################################################################################| ETA:  00:00:00
Loaded 1691 entries from dependency cache.
ERROR: 'tools-sdk' in IMAGE_FEATURES is not a valid image feature. Valid features: dbg-pkgs debug-tweaks dev-pkgs doc-pkgs package-management ptest-pkgs read-only-rootfs splash staticdev-pkgs
ERROR: 'tools-sdk' in IMAGE_FEATURES is not a valid image feature. Valid features: dbg-pkgs debug-tweaks dev-pkgs doc-pkgs package-management ptest-pkgs read-only-rootfs splash staticdev-pkgs
ERROR: Unable to parse /home/daiane/master/sources/meta-fsl-demos/recipes-qt/images/qt-in-use-image.bb: Exited with "1"
ERROR: Command execution failed: Exited with 1
Comment 1 Saul Wold 2013-08-19 22:57:52 UTC
Can you provide more information about what version you are using and a copy of 
your local.conf, I am trying to reproduce this and could not.  It might be 
something in the fsl layers, please also check the output of bitbake -e 
core-image-base and grep for ^PACKAGE_GROUP_ since that's the trigger for valid 
image features.
Comment 2 Daiane 2013-08-20 00:41:32 UTC
Created attachment 1433 [details]
output for bitbake -e core-image-base

This was the result if I *do not* include EXTRA_IMAGE_FEATURES += "tools-sdk" on my local.conf.

If I include this, I get an error.
Comment 3 Daiane 2013-08-20 00:44:12 UTC
Created attachment 1434 [details]
local.conf used to generate the ERROR
Comment 4 Daiane 2013-08-20 00:47:28 UTC
Build Configuration:
BB_VERSION        = "1.19.1"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "Ubuntu-13.04"
TARGET_SYS        = "arm-poky-linux-gnueabi"
MACHINE           = "imx6qsabresd"
DISTRO            = "poky"
DISTRO_VERSION    = "1.4+snapshot-20130820"
TUNE_FEATURES     = "armv7a vfp neon"
TARGET_FPU        = "vfp-neon"
meta              
meta-yocto        = "wand:73b8b10155793bb2d42b0e894606af59c4381e29"
meta-oe           = "wand:d4571b3d94d999ad54d8965f0d049dcfd34da504"
meta-fsl-arm      = "wand-master-next:1663874ee7ff6607a2685929c27695fe21c8ceb8"
meta-fsl-arm-extra = "master-next:4263abc07b86ea8fc087495490f6ed35bb93b119"
meta-fsl-demos    = "oia:833c511f9490c5a5a73e75f11b0c71b88c8b0914"


I included the result for bitbake -e core-image-base when I *do not* have EXTRA_IMAGE_FEATURES += "tools-sdk"

If I include I get the error:
daiane@lola:~/code/master/build$ bitbake -e core-image-base 
Loading cache: 100% |########################################################################################################################################################################| ETA:  00:00:00
Loaded 1688 entries from dependency cache.
ERROR: 'tools-sdk' in IMAGE_FEATURES is not a valid image feature. Valid features: dbg-pkgs debug-tweaks dev-pkgs doc-pkgs package-management ptest-pkgs read-only-rootfs splash staticdev-pkgsETA:  --:--:--
ERROR: 'tools-sdk' in IMAGE_FEATURES is not a valid image feature. Valid features: dbg-pkgs debug-tweaks dev-pkgs doc-pkgs package-management ptest-pkgs read-only-rootfs splash staticdev-pkgs
ERROR: Unable to parse /home/daiane/code/master/sources/meta-fsl-demos/recipes-qt/images/qte-in-use-image.bb: Exited with "1"
ERROR: Command execution failed: Exited with 1





********************
Please, in case you think I can test without meta-fsl-arm on bblayers, let me know what should be the MACHINE
Comment 5 Saul Wold 2013-08-20 02:54:41 UTC
A couple of things, what's different in your meta layer? The git reference is 
not valid in master at all.  Where can I find the meta-fsl-demo layer?

Can you try it 2 ways, one without meta-fsl layers and use MACHINE=qemuarm or 
MACHINE=beagleboard, then also try a pure poky from master.

I wonder if the error we see is miss leading because there is an error with 
ERROR: Unable to parse 
/home/daiane/code/master/sources/meta-fsl-demos/recipes-qt/images/qte-in-use-image.bb: 
Exited with "1"

So I want to see the qte-in-use-image.bb
Comment 6 Daiane 2013-08-20 19:42:43 UTC
This is qte-in-use-image.bb:

https://github.com/Freescale/meta-fsl-demos/blob/master/recipes-qt/images/qte-in-use-image.bb

1) I removed meta-fsl-arm and meta-fsl-demos from bblayers, tested MACHINE="qemuarm" with no error.

2) I used meta-fsl-arm + poky + meta-oe on bblayers (removed meta-fsl-demos only) and tried again with my usual machine. no error.

3) Then I changed my meta-fsl-demos:

$~/master/sources/meta-fsl-demos$ git diff
diff --git a/recipes-qt/images/qt-in-use-common.inc b/recipes-qt/images/qt-in-use-common.inc
index aaaa2a5..c84c1b1 100644
--- a/recipes-qt/images/qt-in-use-common.inc
+++ b/recipes-qt/images/qt-in-use-common.inc
@@ -29,4 +29,4 @@ QT_DEMOS = " \
 
 do_rootfs[depends] += "virtual/kernel:do_populate_sysroot"
 
-inherit image
+inherit core-image

And I got *no* error. So, the root cause seems to be "inherit image" instead of "inherit core-image". Is class image deprecated? Do you have any suggestion?

thanks
Comment 7 Saul Wold 2013-08-20 19:59:31 UTC
Aha!  There's your problem your inheriting image, which does not define any of 
the IMAGE_FEATURES or PACKAGE_GROUPS that are needed. image.bbclass is not 
deprecated it is used by core-image.bbclass.

Your patch is the correct patch to make to the qt-in-use-common.inc file, it 
should be using core-image if you want to rely on being able to use 
IMAGE_FEATURES, so it's not a bug in oe-core but in the fsl-demo layer.
Comment 8 Daiane 2013-08-20 20:07:35 UTC
Well, I'm sorry for reporting the error, as it is not a oe-core error.

As you may see, the qte-in-use-image is at least one years old. And I never got this error before.

And, I was trying to add "tools-sdk" to EXTRA_IMAGE_FEATURES, not IMAGE_FEATURES.

And I was not trying qte-in-use-image, but core-image-base.

That altogether made me think it was a error from oe-core. At least the reported error message.

Thanks a lot for your attention and time.
Comment 9 Otavio Salvador 2013-08-24 17:57:23 UTC
(In reply to comment #7)
> Aha!  There's your problem your inheriting image, which does not define any
> of 
> the IMAGE_FEATURES or PACKAGE_GROUPS that are needed. image.bbclass is not 
> deprecated it is used by core-image.bbclass.
> 
> Your patch is the correct patch to make to the qt-in-use-common.inc file, it 
> should be using core-image if you want to rely on being able to use 
> IMAGE_FEATURES, so it's not a bug in oe-core but in the fsl-demo layer.

I applied Daiane patch in meta-fsl-demos but this workaround a bug. The OE-Core cannot bail out if I am not building the specific image. As Daiane said, she were not /building/ qt-in-use image and OE-Core raised the error in any case.

This sounds me as a bug.
Comment 10 Jessica 2013-08-29 20:22:12 UTC
There're some more info capturedin 5052
Comment 11 Paul Eggleton 2015-01-28 11:56:42 UTC
I've finally sent a fix to simply skip the recipe, so the error only shows up when explicitly building the broken recipe.