Bug 5188 - [webhob-poky/master] "Output" column in Builds table is blank
Summary: [webhob-poky/master] "Output" column in Builds table is blank
Status: VERIFIED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: 1.5
Hardware: All Multiple
: Medium normal
Target Milestone: 1.5 M5
Assignee: Cristiana Voicu
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2013-09-13 14:10 UTC by Belen Barros Pena
Modified: 2013-11-04 15:40 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2013-09-13 14:10:14 UTC 
There is no "output" information coming into the builds table. This column should display the value of IMAGE-FSTYPES if:

* the build includes at least one image recipe among its targets

AND

* the build completes successfully
Comment 1 Belen Barros Pena 2013-09-13 14:42:29 UTC 
webhob-poky/master:aa7bec2e9dffd6901ebe3accf748ce458d1481a3
Comment 2 Cristiana Voicu 2013-10-14 10:04:11 UTC 
Hi Belen,

I want to know what do we display if the target is not an image. Also, I think that the second condition is not needed (the build completes successfully), we could show the output format even when the status is in progress. That's my opinion. Do you agree?

Thanks,
Cristiana
Comment 3 Belen Barros Pena 2013-10-14 10:12:19 UTC 
(In reply to comment #2)
> Hi Belen,
> 
> I want to know what do we display if the target is not an image. 

If the build does not produce any rootfs files, we show nothing in that cell (it is empty).

Also, I
> think that the second condition is not needed (the build completes
> successfully), we could show the output format even when the status is in
> progress. 

Yes we could, but if the build fails, then we would have to wipe out the content of that cell, because the build did not produce any rootfs files (see comment above). 

Basically, this cell is not the value of the IMAGE_FSTYPES variable: it is telling you what rootfs files were produced by the build. If none were produced (because you are not building an image recipe or because the build failed) the cell should be empty. 

I hope this explains. 

That's my opinion. Do you agree?
> 
> Thanks,
> Cristiana
Comment 4 Cristiana Voicu 2013-10-14 12:40:32 UTC 
I've sent a patch to fix this to webhob mailing list.
Comment 5 Belen Barros Pena 2013-11-04 15:40:17 UTC 
verified in dora-toaster:46814c99eed399b6dd9ff9e83260fefe79c23ec8