Bug 525 - quilt: configure fails when using patch @ 2.6.1.81-5b68
Summary: quilt: configure fails when using patch @ 2.6.1.81-5b68
Status: RESOLVED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 0.9
Hardware: x86 Multiple
: Undecided normal
Target Milestone: ---
Assignee: Nitin Kamble
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2010-11-08 10:47 UTC by Beth Flanagan
Modified: 2010-12-21 06:09 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Flanagan 2010-11-08 10:47:59 UTC 
OS: openSuSE 11.3

Issue:
quilt's test for patch -v assumes the version to be at $2. Later versions of patch have modified -v to prepend the version with "GNU", causing the patch version to move to $3 and causing configure of quilt to fail.
Comment 1 Ke Yu 2010-11-08 15:25:20 UTC 
which version of patch does OpenSuSE 11.3 use? i see the latest stable patch is 2.6, and "patch --version" is not with "GNU" prepend:

# patch --version
patch 2.6
Copyright (C) 1988 Larry Wall
Copyright (C) 2003 Free Software Foundation, Inc.
Comment 2 Beth Flanagan 2010-11-08 16:21:52 UTC 
patch -v
GNU patch 2.6.1.81-5b68
Copyright (C) 2003, 2009, 2010 Free Software Foundation, Inc.
Copyright (C) 1988 Larry Wall

This has been mentioned on the quilt-dev list. The PULL request I sent earlier includes the patch provided to quilt-dev:

http://lists.nongnu.org/archive/html/quilt-dev/2010-06/msg00002.html

If you check out the SRPM from openSuSE and look at configure:

PACKAGE_NAME='GNU patch'
Comment 3 Ke Yu 2010-11-08 19:31:10 UTC 
Yeah, detail enough, Thanks Beth for this info. Nitin will fix this bug.
Comment 4 Beth Flanagan 2010-11-09 11:27:30 UTC 
Ke,

I put a Pull request in yesterday from my branch that fixes this issue:

 meta/recipes-devtools/quilt/quilt.inc                      |    3 +-
 meta/recipes-devtools/quilt/quilt/gnu_patch_test_fix.patch |   19
+++++++++++++
 2 files changed, 21 insertions(+), 1 deletion(-)

Beth Flanagan (1):
      quilt: Fixed configure test for patch --version.

Pull URL:
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=eflanagan/quilt_fix