Bug 5275 - bbnote etc just use echo
Summary: bbnote etc just use echo
Status: RESOLVED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: 1.4
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 1.9 M2
Assignee: Paul Eggleton
QA Contact: Lucian Musat
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2013-09-26 10:35 UTC by Ross Burton
Modified: 2015-08-27 15:04 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Burton 2013-09-26 10:35:20 UTC
bbnote (warning, etc) should be identical to using bb.note (.warning, etc) whereas currently they simply do an echo.

Bitbake could open some pipes and then bbnote can echo into them, which bitbake would then read and pass to bb.note.
Comment 1 Paul Eggleton 2014-03-07 16:05:15 UTC
The current state of the patch enabling this is here:

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=paule/shell-logging

There are a couple of concerns:

* There are a few places where we're calling bbwarn where we'll now see these reported as actual warnings, so these will need to be fixed.

* There is a not insignificant performance penalty. If my numbers are to be believed it adds around a minute to the build of core-image-minimal, which is not really desirable.

For these reasons I'm pushing this out to 1.7.
Comment 2 Paul Eggleton 2015-07-10 13:59:30 UTC
I've just sent this for review, finally. We've resolved a lot of the warnings that would otherwise now be shown (in particular those from do_rootfs are now picked up anyway through the log_check code). The performance impact shouldn't be significant; I don't think my earlier benchmarks were very rigorous.