Bug 5453 - Remove the image_fstypes field from the builds table
Summary: Remove the image_fstypes field from the builds table
Status: VERIFIED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium enhancement
Target Milestone: 1.6 M4
Assignee: Cristiana Voicu
QA Contact:
URL:
Whiteboard: needs test fixtures update
Depends on: 5189
Blocks: 5947
  Show dependency tree
 
Reported: 2013-11-04 14:35 UTC by Belen Barros Pena
Modified: 2014-03-18 13:05 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2013-11-04 14:35:34 UTC 
The image_fstypes field in the orm_build table was supposed to store information about a build's output (i.e. the extensions of the rootfs files created during the build, if any). But in its current implementation, the field stores the value of the IMAGE_FSTYPES variable instead. The build output information is provided only via the simple UI, and there is no way to obtain it via the API. To fix this, we should:

* Rename the image_fstypes field to 'output'

* Make sure that it is populated only if build.outcome == 0 and target.is_image == true

* Change the simple interface to display the new 'output' field
Comment 1 Belen Barros Pena 2013-11-05 13:59:43 UTC 
The information the image_fstypes field was supposed to provide is stored by file_name in the target table. People can check the values stored in the IMAGE_FSTYPES variable using the configuration information. Therefore we don't need image_fstypes

We can use file_name to generate the 'output' information in the simple interface.
Comment 2 Cristiana Voicu 2013-11-12 14:02:25 UTC 
I will implement this after we have a patch for 5189, in order to obtain the file_name.
Comment 3 Alexandru Damian 2014-02-20 12:19:43 UTC 
I am removing the image_fstypes field with the addition of Target_Image_File table that will hold generated image files information.

Fixtures needs updating.
Comment 4 Andreea Brandusa Proca 2014-03-05 13:50:48 UTC 
This field is nor removed in master:f03955041d0e44d377ca1c4def630982f24f1e8b.
Comment 5 Alexandru Damian 2014-03-05 14:05:23 UTC 
Well, the patch is not merged into master, as the status says :)
Comment 6 Alexandru Damian 2014-03-11 12:45:24 UTC 
Database schema merged into origin/master
Comment 7 Cristiana Voicu 2014-03-14 14:35:15 UTC 
The image_fstypes field was removed from the build table, so this bug is resolved. The changes needed to replace it is the purpose of bug 5947, so this one can be closed.
Comment 8 Belen Barros Pena 2014-03-18 13:05:41 UTC 
Verified in 

master:e58089b9d708ba176594a758580cc52c23725a5b