Bug 5459 - Version field starts with ":"
Summary: Version field starts with ":"
Status: VERIFIED FIXED
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: unspecified
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.6 M1
Assignee: Alexandru Damian
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2013-11-05 08:47 UTC by Andreea Brandusa Proca
Modified: 2013-12-23 16:18 UTC (History)
3 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreea Brandusa Proca 2013-11-05 08:47:18 UTC 
The version field from Recipe table, has the correct value but starts with ":".

e.g. ":1.21.1-r0"
Comment 1 Alexandru Damian 2013-11-05 15:24:19 UTC 
This is normal. The full format of the version string is:

PE:PV-PR

yet the PE is optional.  However some of the recipes (95 of them to be precise) define PE, so we can't change the format of the version string.
Comment 2 Belen Barros Pena 2013-11-05 17:26:11 UTC 
Can't we strip out the semicolon before storing the value?

Not trying to be anal here: the problem is that the : it's just visual noise. Makes the value harder to read, skim through and compare.
Comment 3 Belen Barros Pena 2013-11-06 12:18:50 UTC 
Right, after some discussion and a bit of thinking, can we do the following:

* If PE exists, use the ':' to separate it from PV
* If PE does not exist, strip out the ':'

This way we keep the character when it's useful, but we get rid of the visual noise when it's not needed.

Thanks!
Comment 4 Belen Barros Pena 2013-11-07 19:13:31 UTC 
By the way, is not only the 'version' in the recipes table, but also the version field in target packages (but not in build packages, for some reason)
Comment 5 Alexandru Damian 2013-12-02 14:45:07 UTC 
In progress review on poky-contrib: toaster/master
Comment 6 Belen Barros Pena 2013-12-23 16:18:12 UTC 
merged to master
Comment 7 Belen Barros Pena 2013-12-23 16:18:37 UTC 
verified in master:3ada51f7aa26fc95d5f9ba4498c0ea54acc6e42e