Bug 5588 - pybootchartgui.py doesn't work with -s option
Summary: pybootchartgui.py doesn't work with -s option
Status: VERIFIED FIXED
Alias: None
Product: Meta-yocto
Classification: Build System, Metadata & Runtime
Component: configuration (show other bugs)
Version: 1.6
Hardware: x86 Multiple
: Medium normal
Target Milestone: 1.6
Assignee: Peter Kjellerstedt
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2013-11-22 10:05 UTC by Yi Zhao
Modified: 2014-02-10 07:34 UTC (History)
4 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Don't know

Attachments
Make the -s option work again (1.50 KB, patch)
2014-01-21 15:18 UTC, Peter Kjellerstedt 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yi Zhao 2013-11-22 10:05:53 UTC 
Git rev: master/215dab864e7cf74394840621ad0754db593708f1

Steps:
1. Build an image
2. Run command ../scripts/pybootchartgui/pybootchartgui.py -s 4 -o chart  tmp/buildstats/core-image-minimal-qemumips/201311221707 to generate the svg files.

Error message: 
#################
$ ../scripts/pybootchartgui/pybootchartgui.py -s 4 -o chart tmp/buildstats/core-image-minimal-qemumips/201311221707
Traceback (most recent call last):
  File "../scripts/pybootchartgui/pybootchartgui.py", line 23, in <module>
    sys.exit(main())
  File "/buildarea3/yzhao1/poky-build/scripts/pybootchartgui/pybootchartgui/main.py", line 156, in main
    res_list = parsing.split_res(res, options.num)
  File "/buildarea3/yzhao1/poky-build/scripts/pybootchartgui/pybootchartgui/parsing.py", line 716, in split_res
    state = ParserState()
NameError: global name 'ParserState' is not defined

##################
Comment 1 Richard Purdie 2013-11-28 15:36:56 UTC 
Peter, would you be able to help with this regression from the latest changes?
Comment 2 Peter Kjellerstedt 2013-11-29 02:17:56 UTC 
I will take a look at it...
Comment 3 Peter Kjellerstedt 2014-01-21 15:18:49 UTC 
Created attachment 1742 [details]
Make the -s option work again

This should make the -s option work again.

During the work to fix this ticket I noticed a couple of other things I wanted to correct/improve in pybootchartgui. I will send these changes (including the fix for this ticket) as a normal batch of patches to the oe-core mailing list.
Comment 5 Yi Zhao 2014-02-10 07:34:10 UTC 
Verified with master/4e9eb77108c7e628ebd00ec848b8bc034802e197