Bug 5688 - bitbake -ccleanall doesn't remove the git2_git.pkg.tar.gz.done
Summary: bitbake -ccleanall doesn't remove the git2_git.pkg.tar.gz.done
Status: VERIFIED FIXED
Alias: None
Product: BitBake
Classification: Build System, Metadata & Runtime
Component: bitbake (show other bugs)
Version: 1.6
Hardware: x86 Multiple
: Undecided normal
Target Milestone: 1.6 M2
Assignee: Robert Yang
QA Contact:
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2013-12-26 15:46 UTC by Robert Yang
Modified: 2014-01-10 06:56 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Yang 2013-12-26 15:46:56 UTC
$ bitbake xf86-video-omapfb -cfetch && bitbake xf86-video-omapfb -ccleanall


The git2_git.pingu.fi.xf86-video-omapfb.tar.gz has been removed from the DL_DIR, but the git2_git.pingu.fi.xf86-video-omapfb.tar.gz.done doesn't, this is because the "open(ud.donestamp, 'w').close()" in try_mirror_url() will create the git2_git.xxx.tar.gz.done, but no one removes (the clean() in fetch2/__init__.py removes the DL_DIR/git2/pkg.done)

This only happens on the git fetcher AFAIK, the following patch will fix the problem:

diff --git a/bitbake/lib/bb/fetch2/git.py b/bitbake/lib/bb/fetch2/git.py
index bd107db..b4b9368 100644
--- a/bitbake/lib/bb/fetch2/git.py
+++ b/bitbake/lib/bb/fetch2/git.py
@@ -283,6 +283,7 @@ class Git(FetchMethod):
 
         bb.utils.remove(ud.localpath, True)
         bb.utils.remove(ud.fullmirror)
+        bb.utils.remove(ud.fullmirror + ".done")
 
     def supports_srcrev(self):
         return True
Comment 1 Robert Yang 2014-01-03 06:42:44 UTC
Merged:

https://bugzilla.yoctoproject.org/show_bug.cgi?id=5688
Comment 2 Yi Zhao 2014-01-10 06:56:12 UTC
Verified with master/e93a345fae7c21652547bec501fcb1f3b6c6427d

#######################
$ find ./downloads/ -name  \*omapfb\*
$
$ bitbake xf86-video-omapfb -c fetch
...
...
$ $ find ./downloads/ -name  \*omapfb\*
./downloads/git2_git.pingu.fi.xf86-video-omapfb.tar.gz
./downloads/git2_git.pingu.fi.xf86-video-omapfb.tar.gz.done
./downloads/git2/git.pingu.fi.xf86-video-omapfb
./downloads/git2/git.pingu.fi.xf86-video-omapfb.done
./downloads/0006-omapfb-port-to-new-xserver-video-API.patch.done
$
$ bitbake xf86-video-omapfb -c cleanall
...
...
$ find ./downloads/ -name  \*omapfb\*
$
######################

The git2_git.pkg.tar.gz.done also be removed.