Bug 5791 - Image install fails when appending piglit because it adds to initramfs
Summary: Image install fails when appending piglit because it adds to initramfs
Status: VERIFIED FIXED
Alias: None
Product: OE-Core
Classification: Build System, Metadata & Runtime
Component: core (show other bugs)
Version: 1.6
Hardware: NUC Multiple
: Medium+ normal
Target Milestone: 1.6
Assignee: Saul Wold
QA Contact:
URL:
Whiteboard: 07 March 2014 - I need some informati...
Depends on:
Blocks:
 
Reported: 2014-02-05 13:31 UTC by Alexandru Palalau
Modified: 2014-03-07 19:08 UTC (History)
6 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: Yes (doc changes required)


Attachments
pn-buildlist files (2.92 KB, application/x-gtar)
2014-02-06 10:13 UTC, Alexandru Palalau
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandru Palalau 2014-02-05 13:31:56 UTC
Build Configuration:
BB_VERSION        = "1.21.1"
BUILD_SYS         = "x86_64-linux"
NATIVELSBSTRING   = "Fedora-19"
TARGET_SYS        = "x86_64-poky-linux"
MACHINE           = "nuc"
DISTRO            = "poky"
DISTRO_VERSION    = "1.5+snapshot-20140205"
TUNE_FEATURES     = "m64 corei7"
TARGET_FPU        = ""
meta              
meta-yocto        
meta-yocto-bsp    = "master:4e9eb77108c7e628ebd00ec848b8bc034802e197"
meta-intel        
meta-nuc          = "master:c5ca9f67121bff0b7400a175f005212234906b37"

At this moment, we have piglit added by default to the sato-sdk image.
Adding IMAGE_INSTALL_append = " piglit" to the local.conf and building a sato image (or sato-sdk) results in image not being installed on BSP.
The following message is presented after answering to the installation location/storage question:

***********************************
Installing image on /dev/sda ...
cat: write error: Invalid argument
Installation image failed

sh: cannot set terminal process group(-1): Inappropriate ioctl for device
sh: no job control in this shell
***********************************

The piglit testsuite can be successfully run in live boot.
Comment 1 Alexandru Palalau 2014-02-06 10:13:15 UTC
Created attachment 1759 [details]
pn-buildlist files

The pn-buildlist files are from both scenarios(with/without piglit appended) to a sato-sdk image for nuc
Comment 2 Ross Burton 2014-02-06 11:02:11 UTC
The package list is identical, so there must be a difference in the rootfs.
Comment 3 Saul Wold 2014-02-06 16:02:04 UTC
Please use CORE_IMAGE_EXTRA_INSTALL instead of IMAGE_INSTALL
Comment 4 Alexandru Palalau 2014-02-07 11:08:22 UTC
That worked fine although it's just a workaround.
Thanks
Comment 5 Saul Wold 2014-02-20 20:32:39 UTC
You point out an interesting issue with the usage of IMAGE_INSTALL to generally 
add things to the image vs using CORE_IMAGE_EXTRA_INSTALL.

Since you don't like CORE_IMAGE_EXTRA_INSTALL and since adding a package to 
IMAGE_INSTALL affects both the image you are building and the initramfs image, 
another option is to add an explict IMAGE_INSTALL_append_pn-<image name> = " 
<package names>"to your local.conf this will cause that set  of packages in 
<package names> to only be installed in that particular image that you define 
in <image name>.

The other option is we change IMAGE_INSTALL's meaning somehow for the initramfs 
image specificly so that it can not be appended to, but I don't think that's 
the right solution either.
Comment 7 Alexandru Palalau 2014-03-04 08:15:47 UTC
I could successfully install the image after the mentioned commit.
Comment 8 Alexandru Palalau 2014-03-06 10:47:03 UTC
Somehow I changed the status. 
Changing it back to Resolved/Fixed
Comment 9 Alexandru Palalau 2014-03-06 10:47:40 UTC
Setting to Verified as per Comment #7
Sorry for the missunderstanding
Comment 10 Scott Rifenbark 2014-03-07 19:08:03 UTC
Hi, 

For the documentation component for this fixed bug, it seems like I need to expand on the definitions of IMAGE_INSTALL and CORE_IMAGE_EXTRA_INSTALL, both of which we have in our glossary (http://www.yoctoproject.org/docs/1.6/ref-manual/ref-manual.html#var-IMAGE_INSTALL and http://www.yoctoproject.org/docs/1.6/ref-manual/ref-manual.html#var-CORE_IMAGE_EXTRA_INSTALL.  

Would providing the general information that Saul points out in Comment 5 cover this well enough?

Thanks, 
Scott