Bug 5878 - We should keep some state of Toaster tables
Summary: We should keep some state of Toaster tables
Status: RESOLVED DUPLICATE of bug 6126
Alias: None
Product: Toaster
Classification: Build System, Metadata & Runtime
Component: toaster (show other bugs)
Version: unspecified
Hardware: All Multiple
: Medium normal
Target Milestone: 1.7 M4
Assignee: Alexandru Damian
QA Contact: Mihail Stanciu
URL:
Whiteboard:
Depends on:
Blocks:
 
Reported: 2014-02-25 13:03 UTC by Belen Barros Pena
Modified: 2014-09-19 14:10 UTC (History)
5 users (show)

See Also:
OS type for building Yocto: ---
Type of Regression: ---
Verified:
Documentation change: No (bug/feature does not impact docs)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Belen Barros Pena 2014-02-25 13:03:48 UTC 
Right now the cookie we have in place to keep state of Toaster tables seems to cover only the Edit columns menu (which columns are shown and which hidden). We should probably cover all other elements as well, which include:

* The number selected in the 'Show rows' dropdown menu
* The sorting applied
* The page number I was in
* A filter applied
* A search query performed

So if in the All builds table I select to see only Today's builds by applying a filter in the Completed on column, and then click on a build, when I return to the All builds table the filter will still be applied.
Comment 1 Belen Barros Pena 2014-03-13 15:59:30 UTC 
On second thoughts, this might not be such a good idea. Let's not touch it for the moment.
Comment 2 Belen Barros Pena 2014-03-28 09:44:14 UTC 
Sorry for all the back and forth with this one. We should probably keep
 
* the "Show rows" selection
* the sorting applied

Otherwise, it resets every time, which is a bit maddening.
Comment 3 Alexandru Damian 2014-04-07 11:20:00 UTC 
A patch to remember the number of rows across searches in the same page has been submitted for review on poky-contrib/adamian/20140408-tables-5878

Proposing that the feature about remembering the sorting and the number-of-rows across sessions (e.g. browser closing and re-opening) be moved for 1.7.
Comment 4 Belen Barros Pena 2014-04-07 12:20:34 UTC 
(In reply to comment #3)
> A patch to remember the number of rows across searches in the same page has
> been submitted for review on poky-contrib/adamian/20140408-tables-5878

This seems to be working: "Show rows" selection is kept when I search(although not between pages or sessions).

> 
> Proposing that the feature about remembering the sorting and the
> number-of-rows across sessions (e.g. browser closing and re-opening) be
> moved for 1.7.

Done: bug 6126
Comment 6 Mihail Stanciu 2014-07-28 14:02:43 UTC 
Number of rows resets to page default (25 for tasks, 100 for recipes and packages) when pressing the search button.

Tested on master branch 8b7116d25ed6255a03895d835e5a0560858ab496
Fedora 20 OS
Firefox 31.0 browser
Comment 7 Alexandru Damian 2014-07-31 14:09:22 UTC 
Rescheduling.
Comment 8 Alexandru Damian 2014-08-29 16:49:48 UTC 
Rescheduled for M4, this is not an enhancement, but a normal bug.
Comment 9 Belen Barros Pena 2014-09-19 14:10:20 UTC 
The functionality added with bug 6126 covers the request here. It does not work across browser sessions, but it does within the same session across pages and searches, which is good enough.

Setting this bug as duplicate.

*** This bug has been marked as a duplicate of bug 6126 ***